Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(intersection): generate yield stuck detect area from multiple lanes #5883

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Dec 15, 2023

Description

generate yield stuck detect area for each attention lanelet between
-the intersection point of its centerline and ego path

  • the point which is yield_stuck.distance_threshold before that point

autowarefoundation/autoware_launch#742

Related links

https://tier4.atlassian.net/browse/RT1-4135

Tests performed

evaluator: https://evaluation.tier4.jp/evaluation/reports/d2d269d3-bb30-5c65-93fc-651072f26ff6?project_id=prd_jt

left turn

image

right turn

image

Notes for reviewers

Interface changes

none.

Effects on system behavior

none.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Mamoru Sobue <[email protected]>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Dec 15, 2023
@soblin soblin changed the title Fix/intersection/yield stuck multiple lane fix(intersection): generate yield stuck detect area from multiple lanes Dec 15, 2023
@soblin soblin force-pushed the fix/intersection/yield-stuck-multiple-lane branch from d4fa3d8 to a861078 Compare December 15, 2023 08:30
Signed-off-by: Mamoru Sobue <[email protected]>
@soblin soblin marked this pull request as ready for review December 18, 2023 04:47
@soblin soblin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 18, 2023
Signed-off-by: Mamoru Sobue <[email protected]>
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Attention: 95 lines in your changes are missing coverage. Please review.

Comparison is base (1b6cc51) 15.35% compared to head (e1895bb) 15.34%.
Report is 21 commits behind head on main.

Files Patch % Lines
...behavior_velocity_intersection_module/src/util.cpp 0.00% 67 Missing ⚠️
...ity_intersection_module/src/scene_intersection.cpp 0.00% 24 Missing ⚠️
...ehavior_velocity_intersection_module/src/debug.cpp 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5883      +/-   ##
==========================================
- Coverage   15.35%   15.34%   -0.01%     
==========================================
  Files        1747     1747              
  Lines      120045   120116      +71     
  Branches    36534    36589      +55     
==========================================
  Hits        18429    18429              
- Misses      80963    81034      +71     
  Partials    20653    20653              
Flag Coverage Δ *Carryforward flag
differential 5.25% <0.00%> (?)
total 15.35% <ø> (+<0.01%) ⬆️ Carriedforward from 1b6cc51

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin soblin merged commit b9fa290 into autowarefoundation:main Dec 18, 2023
20 of 25 checks passed
@soblin soblin deleted the fix/intersection/yield-stuck-multiple-lane branch December 18, 2023 13:07
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants