-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ground_segmentation): add omp parallel for #5791
fix(ground_segmentation): add omp parallel for #5791
Conversation
Signed-off-by: badai-nguyen <[email protected]>
Signed-off-by: badai-nguyen <[email protected]>
This pull request has been automatically marked as stale because it has not had recent activity. |
@badai-nguyen do you have any plans for this PR, or should we close it for now? |
@miursh I'm sorry for missed your mention. I updated the result I tested this PR on Bench PC which shows the decrease of processing_time so I will open it and hope can merge this PR. Could you review or assign someone to review it? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5791 +/- ##
=======================================
Coverage 14.64% 14.65%
=======================================
Files 1899 1899
Lines 130282 130278 -4
Branches 38311 38303 -8
=======================================
+ Hits 19083 19087 +4
+ Misses 89784 89782 -2
+ Partials 21415 21409 -6
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This pull request has been automatically marked as stale because it has not had recent activity. |
Description
🤖[deprecated] Generated by Copilot at 5cb8eab
This pull request enhances the
scan_ground_filter_nodelet
class in theperception/ground_segmentation
package by parallelizing and refactoring its point cloud processing logic. It uses OpenMP to speed up the classification of points into ground and non-ground segments, and it simplifies the input and output of some functions by using vectors of point indices.Related Link
TIER IV INTERNAL LINK
Tests performed
I've tested by logging_simulator on my PC using sample-rosbag and internal bus rosbag and confirmed the processing time of ground_segmentation is decreased.
I've also tested on the test bench pc for xx1 and the result shows that with suitable
omp_set_num_threads
or without setomp_set_num_threads
, theprocessing_time
is improved 22%.omp_set_num_threads
: 1omp_set_num_threads
: 2omp_set_num_threads
: 10threadsomp_set_num_threads
no setEffects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.