-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(run_out): use the predicted object's velocity and covariance for the collision detection #5672
Merged
TomohitoAndo
merged 3 commits into
autowarefoundation:main
from
TomohitoAndo:feat/run-out-use-obejct-velocity
Nov 26, 2023
Merged
feat(run_out): use the predicted object's velocity and covariance for the collision detection #5672
TomohitoAndo
merged 3 commits into
autowarefoundation:main
from
TomohitoAndo:feat/run-out-use-obejct-velocity
Nov 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the collision detection Signed-off-by: Tomohito Ando <[email protected]>
Signed-off-by: Tomohito Ando <[email protected]>
github-actions
bot
added
type:documentation
Creating or refining documentation. (auto-assigned)
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
labels
Nov 24, 2023
4 tasks
TomohitoAndo
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Nov 24, 2023
TomohitoAndo
requested review from
mkuri,
shmpwk and
tkimura4
as code owners
November 24, 2023 12:43
Signed-off-by: Tomohito Ando <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5672 +/- ##
===========================================
+ Coverage 15.32% 19.14% +3.81%
===========================================
Files 1721 15 -1706
Lines 118559 1379 -117180
Branches 37995 685 -37310
===========================================
- Hits 18169 264 -17905
+ Misses 79657 817 -78840
+ Partials 20733 298 -20435
☔ View full report in Codecov by Sentry. |
takayuki5168
approved these changes
Nov 25, 2023
danielsanchezaran
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Dec 15, 2023
… the collision detection (autowarefoundation#5672) * feat(run_out): use the predicted object's velocity and covariance for the collision detection Signed-off-by: Tomohito Ando <[email protected]> * chore: update readme Signed-off-by: Tomohito Ando <[email protected]> * fix calculation Signed-off-by: Tomohito Ando <[email protected]> --------- Signed-off-by: Tomohito Ando <[email protected]>
TomohitoAndo
added a commit
to tier4/autoware.universe
that referenced
this pull request
Apr 11, 2024
… the collision detection (autowarefoundation#5672) * feat(run_out): use the predicted object's velocity and covariance for the collision detection Signed-off-by: Tomohito Ando <[email protected]> * chore: update readme Signed-off-by: Tomohito Ando <[email protected]> * fix calculation Signed-off-by: Tomohito Ando <[email protected]> --------- Signed-off-by: Tomohito Ando <[email protected]>
Merged
4 tasks
TomohitoAndo
added a commit
to tier4/autoware.universe
that referenced
this pull request
Apr 12, 2024
… the collision detection (autowarefoundation#5672) * feat(run_out): use the predicted object's velocity and covariance for the collision detection Signed-off-by: Tomohito Ando <[email protected]> * chore: update readme Signed-off-by: Tomohito Ando <[email protected]> * fix calculation Signed-off-by: Tomohito Ando <[email protected]> --------- Signed-off-by: Tomohito Ando <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
type:documentation
Creating or refining documentation. (auto-assigned)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added option to use the object's velocity and covariance for the collision detection, and set this as default option.
Currently, objects in run out module have the min and max velocity, which is specified in the parameter.
For example, if the min velocity is 0km/h, and the max velocity is 5km/h, obstacle's polygon to calculate the time to collision is like bellow image.
In this PR, option to use min and max velocity are calculated from the object's velocity and its covariance is added.
PR for the launch:
Tests performed
PSim
Scenario Test (TIER IV Internal)
run_out_object_vel.mp4
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.