Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(run_out): use the predicted object's velocity and covariance for the collision detection #5672

Conversation

TomohitoAndo
Copy link
Contributor

@TomohitoAndo TomohitoAndo commented Nov 24, 2023

Description

I added option to use the object's velocity and covariance for the collision detection, and set this as default option.

Currently, objects in run out module have the min and max velocity, which is specified in the parameter.
For example, if the min velocity is 0km/h, and the max velocity is 5km/h, obstacle's polygon to calculate the time to collision is like bellow image.
image

In this PR, option to use min and max velocity are calculated from the object's velocity and its covariance is added.
image

PR for the launch:

Tests performed

PSim
Scenario Test (TIER IV Internal)

run_out_object_vel.mp4

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

… the collision detection

Signed-off-by: Tomohito Ando <[email protected]>
Signed-off-by: Tomohito Ando <[email protected]>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Nov 24, 2023
@TomohitoAndo TomohitoAndo added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 24, 2023
@TomohitoAndo TomohitoAndo marked this pull request as ready for review November 24, 2023 12:43
@TomohitoAndo TomohitoAndo marked this pull request as draft November 24, 2023 12:49
Signed-off-by: Tomohito Ando <[email protected]>
@TomohitoAndo TomohitoAndo marked this pull request as ready for review November 24, 2023 15:54
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (765a596) 15.32% compared to head (8eb6f6a) 19.14%.
Report is 62 commits behind head on main.

Files Patch % Lines
...r_velocity_run_out_module/src/dynamic_obstacle.cpp 0.00% 21 Missing ⚠️
...g/behavior_velocity_run_out_module/src/manager.cpp 28.57% 0 Missing and 5 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5672       +/-   ##
===========================================
+ Coverage   15.32%   19.14%    +3.81%     
===========================================
  Files        1721       15     -1706     
  Lines      118559     1379   -117180     
  Branches    37995      685    -37310     
===========================================
- Hits        18169      264    -17905     
+ Misses      79657      817    -78840     
+ Partials    20733      298    -20435     
Flag Coverage Δ
differential 19.14% <7.14%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TomohitoAndo TomohitoAndo merged commit 49112d9 into autowarefoundation:main Nov 26, 2023
27 of 30 checks passed
@TomohitoAndo TomohitoAndo deleted the feat/run-out-use-obejct-velocity branch November 29, 2023 10:40
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Dec 15, 2023
… the collision detection (autowarefoundation#5672)

* feat(run_out): use the predicted object's velocity and covariance for the collision detection

Signed-off-by: Tomohito Ando <[email protected]>

* chore: update readme

Signed-off-by: Tomohito Ando <[email protected]>

* fix calculation

Signed-off-by: Tomohito Ando <[email protected]>

---------

Signed-off-by: Tomohito Ando <[email protected]>
TomohitoAndo added a commit to tier4/autoware.universe that referenced this pull request Apr 11, 2024
… the collision detection (autowarefoundation#5672)

* feat(run_out): use the predicted object's velocity and covariance for the collision detection

Signed-off-by: Tomohito Ando <[email protected]>

* chore: update readme

Signed-off-by: Tomohito Ando <[email protected]>

* fix calculation

Signed-off-by: Tomohito Ando <[email protected]>

---------

Signed-off-by: Tomohito Ando <[email protected]>
TomohitoAndo added a commit to tier4/autoware.universe that referenced this pull request Apr 12, 2024
… the collision detection (autowarefoundation#5672)

* feat(run_out): use the predicted object's velocity and covariance for the collision detection

Signed-off-by: Tomohito Ando <[email protected]>

* chore: update readme

Signed-off-by: Tomohito Ando <[email protected]>

* fix calculation

Signed-off-by: Tomohito Ando <[email protected]>

---------

Signed-off-by: Tomohito Ando <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants