Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(start_planner, goal_planner): remove inappropriate reference value #5618

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Nov 17, 2023

Description

remove inappropriate reference value

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 17, 2023
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 185 lines in your changes are missing coverage. Please review.

Comparison is base (765a596) 15.32% compared to head (45eaf7c) 15.29%.
Report is 23 commits behind head on main.

Files Patch % Lines
.../scene_module/goal_planner/goal_planner_module.cpp 1.72% 113 Missing and 1 partial ⚠️
...er/src/scene_module/avoidance/avoidance_module.cpp 0.00% 34 Missing and 2 partials ⚠️
.../scene_module/goal_planner/goal_planner_module.hpp 15.78% 15 Missing and 1 partial ⚠️
...cene_module/start_planner/start_planner_module.cpp 0.00% 7 Missing ⚠️
...e/behavior_path_planner/utils/avoidance/helper.hpp 0.00% 4 Missing ⚠️
...ath_planner/src/scene_module/avoidance/manager.cpp 0.00% 0 Missing and 4 partials ⚠️
...rivable_area_expansion/drivable_area_expansion.cpp 40.00% 0 Missing and 3 partials ⚠️
...vior_path_planner/src/utils/start_planner/util.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5618      +/-   ##
==========================================
- Coverage   15.32%   15.29%   -0.03%     
==========================================
  Files        1721     1721              
  Lines      118559   119015     +456     
  Branches    37995    38376     +381     
==========================================
+ Hits        18169    18209      +40     
- Misses      79657    80010     +353     
- Partials    20733    20796      +63     
Flag Coverage Δ *Carryforward flag
differential 12.66% <3.64%> (?)
total 15.35% <40.00%> (+0.02%) ⬆️ Carriedforward from 017aed4

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kosuke55 kosuke55 merged commit 30bc07d into main Nov 17, 2023
34 of 37 checks passed
@kosuke55 kosuke55 deleted the fix/reference branch November 17, 2023 09:53
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants