-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(out_of_lane): improve reuse of previous decision #5611
Merged
maxime-clem
merged 3 commits into
autowarefoundation:main
from
maxime-clem:feat/out_of_lane-project_reused_stop_point-universe
Nov 16, 2023
Merged
feat(out_of_lane): improve reuse of previous decision #5611
maxime-clem
merged 3 commits into
autowarefoundation:main
from
maxime-clem:feat/out_of_lane-project_reused_stop_point-universe
Nov 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maxime CLEMENT <[email protected]>
Signed-off-by: Maxime CLEMENT <[email protected]>
Signed-off-by: Maxime CLEMENT <[email protected]>
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
Nov 16, 2023
4 tasks
maxime-clem
changed the title
feat(out_of_lane): improve reuse of previous decision
feat(out_of_lane): improve reuse of previous decision
Nov 16, 2023
maxime-clem
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Nov 16, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5611 +/- ##
==========================================
+ Coverage 15.32% 15.35% +0.02%
==========================================
Files 1721 1721
Lines 118559 118488 -71
Branches 37995 38001 +6
==========================================
+ Hits 18169 18188 +19
+ Misses 79657 79542 -115
- Partials 20733 20758 +25
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
maxime-clem
requested review from
shmpwk,
takayuki5168 and
tkimura4
as code owners
November 16, 2023 13:18
takayuki5168
approved these changes
Nov 16, 2023
maxime-clem
deleted the
feat/out_of_lane-project_reused_stop_point-universe
branch
November 16, 2023 23:26
takayuki5168
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Nov 22, 2023
…tion#5611) Signed-off-by: Maxime CLEMENT <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve the reuse of the previous decision in the
out_of_lane
module, avoiding bugs when the path changes suddenly.Tests performed
Psim
Evaluator (TIER IV INTERNAL LINK): https://evaluation.tier4.jp/evaluation/reports/c2665660-1e2f-5aca-8a75-54820dd34155?project_id=prd_jt
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.