Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_perception_launch): create 2d detection evaluation branch #5610

Conversation

YoshiRi
Copy link
Contributor

@YoshiRi YoshiRi commented Nov 16, 2023

Description

This PR enables user to run 2d perception node only so that its result can be evaluated with [driving_log_replayer].(https://github.com/tier4/driving_log_replayer/blob/develop/driving_log_replayer/launch/perception_2d.launch.py).

  • supposed tasks
    • yolox roi detection
    • bytetrack roi tracking

for reviewers

Please check default yolo model and its path so that driving_log_replayer in webauto can properly access it.

        <let name="yolox-model-name" value="yolox-sPlus-opt"/>
        <let name="yolox_data_path" value="$(env HOME)/autoware_data"/>
        <let name="yolox_output_base" value="/perception/object_recognition/detection"/>
        <let name="bytetrack_output_base" value="/perception/object_recognition/detection/tracked"/>

Related links

Tests performed

Tested with my local environment and odaiba rosbag data.

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Nov 16, 2023
@miursh
Copy link
Contributor

miursh commented Dec 13, 2023

@YoshiRi Do we still need this? If not, may I close this PR for now?

@YoshiRi
Copy link
Contributor Author

YoshiRi commented Dec 14, 2023

If not, may I close this PR for now?
Yes. Because currently perception_2d evaluation is not available.

@YoshiRi YoshiRi closed this Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants