refactor(operation_mode_transition_manager): rework parameters #5601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: PhoebeWu21 <[email protected]>
Signed-off-by: PhoebeWu21 <[email protected]>
Signed-off-by: PhoebeWu21 <[email protected]>
github-actions
bot
added
type:documentation
satoshi-ota
approved these changes
Nov 22, 2023
TakaHoribe
approved these changes
Nov 22, 2023
satoshi-ota
added
the
run:build-and-test-differential
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5601 +/- ##
=======================================
Coverage 14.78% 14.78%
=======================================
Files 1684 1684
Lines 116836 116836
Branches 36269 36269
=======================================
Hits 17279 17279
Misses 80052 80052
Partials 19505 19505
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
PhoebeWu21
deleted the
refactor-node-config-operation_mode_transition_manager
branch
danielsanchezaran
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Dec 15, 2023
…arefoundation#5601) * refactor(operation_mode_transition_manager): rework parameters Signed-off-by: PhoebeWu21 <[email protected]> * refactor(operation_mode_transition_manager): rework parameters Signed-off-by: PhoebeWu21 <[email protected]> * refactor(operation_mode_transition_manager): rework parameters Signed-off-by: PhoebeWu21 <[email protected]> --------- Signed-off-by: PhoebeWu21 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement the ROS Node configuration layout described in https://github.com/orgs/autowarefoundation/discussions/3371 for the
operation_mode_transition_managerpackage.Tests performed
Package successfully build and launch locally.
colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release --packages-up-to operation_mode_transition_managerEffects on system behavior
More reliable and faster parameter configuration file creation.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.