Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(run_out): add maintainer #5598

Merged

Conversation

TomohitoAndo
Copy link
Contributor

@TomohitoAndo TomohitoAndo commented Nov 15, 2023

Description

Added the maintainer of run_out module.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Tomohito Ando <[email protected]>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 15, 2023
@TomohitoAndo TomohitoAndo added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 15, 2023
@TomohitoAndo
Copy link
Contributor Author

@mkuri @tkimura4 @shmpwk
This PR just adds the maintainer.
Could you approve? 🙏

Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkimura4 tkimura4 enabled auto-merge (squash) November 15, 2023 14:46
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a2b114d) 14.71% compared to head (a6f6715) 14.86%.
Report is 95 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5598      +/-   ##
==========================================
+ Coverage   14.71%   14.86%   +0.14%     
==========================================
  Files        1665     1665              
  Lines      116223   116261      +38     
  Branches    36027    36557     +530     
==========================================
+ Hits        17107    17285     +178     
+ Misses      79733    79419     -314     
- Partials    19383    19557     +174     
Flag Coverage Δ *Carryforward flag
differential 19.30% <ø> (?)
total 14.71% <ø> (+<0.01%) ⬆️ Carriedforward from a2b114d

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tkimura4 tkimura4 merged commit 7fb4b68 into autowarefoundation:main Nov 15, 2023
35 of 36 checks passed
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants