fix(bytetrack): fix uninteded roi value error due to casting int to uint #5589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yoshiri <[email protected]>
github-actions
bot
added
the
component:perception
YoshiRi
added
the
run:build-and-test-differential
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5589 +/- ##
==========================================
- Coverage 14.77% 14.77% -0.01%
==========================================
Files 1663 1663
Lines 115150 115156 +6
Branches 35519 35519
==========================================
Hits 17013 17013
- Misses 78930 78936 +6
Partials 19207 19207
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
miursh
reviewed
Nov 16, 2023
miursh
reviewed
Nov 20, 2023
miursh
approved these changes
Nov 20, 2023
|
OK. This is just quick fix. So I will merge it. |
takayuki5168
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Nov 22, 2023
…int (autowarefoundation#5589) * fix uint32 conversion bug in bytetrack Signed-off-by: yoshiri <[email protected]> * refactor outside xy variable --------- Signed-off-by: yoshiri <[email protected]>
danielsanchezaran
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Dec 15, 2023
…int (autowarefoundation#5589) * fix uint32 conversion bug in bytetrack Signed-off-by: yoshiri <[email protected]> * refactor outside xy variable --------- Signed-off-by: yoshiri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sometimes bytetrack publish invalid roi with very large x or y offset value like
4294967293.I found this is caused by mis-type casting from bytetrack roi
int32to ros message roiuint32.So I fixed message conversion part.
🤖 Generated by Copilot at 7c8e94f
Fix bytetrack node crash when roi is outside of image. Adjust roi values to fit image boundaries and message type in
perception/bytetrack/src/bytetrack_node.cpp.Tests performed
Tested with yolo roi and odaiba video image.
Original yolo roi do not publish invalid rois and after this PR, bytetrack also publish invalid rois.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.