Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(pose_instability_detector, ar_tag_based_localizer): specify file path using get_package_share_directory #5588

Merged

Conversation

KYabuuchi
Copy link
Contributor

Description

By using ament_index_cpp::get_package_share_directory, the path to the config file can be specified from the package path.

Tests performed

colcon test --event-handlers console_cohesion+ \
   --packages-select ar_tag_based_localizer pose_instability_detector

Effects on system behavior

It does not effect the system behavior.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:localization Vehicle's position determination in its environment. (auto-assigned) label Nov 15, 2023
@KYabuuchi KYabuuchi marked this pull request as ready for review November 15, 2023 06:49
@KYabuuchi KYabuuchi added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 15, 2023
@KYabuuchi
Copy link
Contributor Author

@SakodaShintaro please review as a representative 🙏

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (765a596) 15.32% compared to head (6e178b2) 15.32%.
Report is 1 commits behind head on main.

Files Patch % Lines
...sed_localizer/ar_tag_based_localizer/test/test.cpp 0.00% 0 Missing and 2 partials ⚠️
...calization/pose_instability_detector/test/test.cpp 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5588      +/-   ##
==========================================
- Coverage   15.32%   15.32%   -0.01%     
==========================================
  Files        1721     1721              
  Lines      118559   118560       +1     
  Branches    37995    37998       +3     
==========================================
- Hits        18169    18167       -2     
  Misses      79657    79657              
- Partials    20733    20736       +3     
Flag Coverage Δ *Carryforward flag
differential 32.81% <0.00%> (?)
total 15.32% <ø> (-0.01%) ⬇️ Carriedforward from 765a596

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is a good function.
LGTM

@KYabuuchi KYabuuchi merged commit b5d6c51 into autowarefoundation:main Nov 15, 2023
30 of 32 checks passed
@KYabuuchi KYabuuchi deleted the refactor/specify_file_path branch November 15, 2023 07:23
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Nov 22, 2023
…file path using get_package_share_directory (autowarefoundation#5588)

* use get_package_share_directory

Signed-off-by: Kento Yabuuchi <[email protected]>

* use get_package_share_directory in pose_instability_detector

Signed-off-by: Kento Yabuuchi <[email protected]>

---------

Signed-off-by: Kento Yabuuchi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants