refactor(Vehicle_cmd_gate): rework parameters #5579
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:control
karishma1911
changed the title
karishma1911
changed the title
karishma1911
changed the title
karishma1911
force-pushed
the
vehicle_cmd_gate_module
branch
from
6d70015 to
907f5b4
Compare
github-actions
bot
added
the
type:ci
…utowarefoundation#5554) * refactor(goal_planner): refactoring plan flow and add post process Signed-off-by: kosuke55 <[email protected]> do not decel when searching Signed-off-by: kosuke55 <[email protected]> rename planPullOver Signed-off-by: kosuke55 <[email protected]> * add plan flow Signed-off-by: kosuke55 <[email protected]> * add reason of early return Signed-off-by: kosuke55 <[email protected]> * typo Signed-off-by: kosuke55 <[email protected]> * fix path_candidate_ Signed-off-by: kosuke55 <[email protected]> * pub path candidate after approval Signed-off-by: kosuke55 <[email protected]> --------- Signed-off-by: kosuke55 <[email protected]> Signed-off-by: karishma <[email protected]>
Signed-off-by: karishma <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]> Signed-off-by: karishma <[email protected]>
Signed-off-by: karishma <[email protected]>
karishma1911
force-pushed
the
vehicle_cmd_gate_module
branch
from
907f5b4 to
5ee3aa8
Compare
karishma1911
requested review from
rej55,
kosuke55,
kyoichi-sugahara,
satoshi-ota,
shmpwk,
taikitanaka3,
takayuki5168,
purewater0901 and
zulfaqar-azmi-t4
as code owners
github-actions
bot
added
the
component:planning
|
Hi @karishma1911 Thanks for your contribution. But this PR seems to include unnecessary commits. Could you rebase this PR with latest main branch? |
|
Due to uncommitted changes has been pushed in this PR, I want to close this PR |
|
@karishma1911 OK. Please close this PR. I'll review #5652. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement the ROS Node configuration layout described in https://github.com/orgs/autowarefoundation/discussions/3371 for the vehicle_cmd_gate package.
Remove the default value from the source code in order to ensure all parameter values are passed from the parameter files.
Create the schema
Tests performed
Not applicable.
Effects on system behavior
More reliable and faster parameter configuration file creation.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.