Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pointcloud_preprocessor): update azimuth and distance in distortion_correction_node #5560

Closed
wants to merge 22 commits into from

style(pre-commit): autofix

dffbd56
Select commit
Loading
Failed to load commit list.
Closed

feat(pointcloud_preprocessor): update azimuth and distance in distortion_correction_node #5560

style(pre-commit): autofix
dffbd56
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Nov 14, 2023 in 37s

CodeScene PR Check

✅ Code Health Quality Gates: OK

  • Declining Code Health: 1 findings(s) 🚩
  • Improving Code Health: 0 findings(s) ✅
  • Affected Hotspots: 0 files(s) 🔥

Recommended Review Level: Detailed -- Increased risk for defects: The risk is higher as much of the code in this repo (99% of all commits) is written by other authors.
View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method distortion_corrector.cpp: DistortionCorrectorComponent::undistortPointCloud

Annotations

Check warning on line 311 in sensing/pointcloud_preprocessor/src/distortion_corrector/distortion_corrector.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method 

DistortionCorrectorComponent::undistortPointCloud increases in cyclomatic complexity from 21 to 22, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
View more details on CodeScene Delta Analysis