refactor(goal_planner): refactor select path #5559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosuke55
requested review from
rej55,
kyoichi-sugahara,
satoshi-ota,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
tkimura4,
purewater0901 and
zulfaqar-azmi-t4
as code owners
github-actions
bot
added
the
component:planning
kosuke55
force-pushed
the
refactor/goal_planner_select_path
branch
2 times, most recently
from
991cee4 to
9815f5f
Compare
kosuke55
added
the
run:build-and-test-differential
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5559 +/- ##
==========================================
+ Coverage 15.25% 15.29% +0.03%
==========================================
Files 1717 1717
Lines 118370 118456 +86
Branches 37912 37983 +71
==========================================
+ Hits 18057 18116 +59
- Misses 79651 79655 +4
- Partials 20662 20685 +23
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
7 tasks
Signed-off-by: kosuke55 <[email protected]>
kosuke55
force-pushed
the
refactor/goal_planner_select_path
branch
from
b37aee2 to
eaca1ac
Compare
kosuke55
force-pushed
the
refactor/goal_planner_select_path
branch
from
e503027 to
eaca1ac
Compare
takayuki5168
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Nov 22, 2023
Signed-off-by: kosuke55 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simplify selectSafePath and do not update thread_data_ internally
Related links
before this PR merge
Tests performed
psim
evaluator_description: refactor/goal_planner_select_path
2023/11/13 https://evaluation.tier4.jp/evaluation/reports/c7ce83db-31f7-592a-8619-8bfa9d9a9633/?project_id=prd_jt
evaluator_description: refactor/goal_planner_select_path
2023/11/14 https://evaluation.tier4.jp/evaluation/reports/8eeaa795-f1ca-5a26-81cc-492c7b4078a3/?project_id=prd_jt
evaluator_description: refactor/goal_planner_select_path
2023/11/15 https://evaluation.tier4.jp/evaluation/reports/17dff02f-d1ab-5eb7-9f61-700243053332/?project_id=prd_jt
Notes for reviewers
Interface changes
none
Effects on system behavior
none
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.