-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(avoidance): fix wrong reason for unavoidable situation #5558
fix(avoidance): fix wrong reason for unavoidable situation #5558
Conversation
Signed-off-by: satoshi-ota <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5558 +/- ##
==========================================
- Coverage 15.26% 15.25% -0.02%
==========================================
Files 1713 1713
Lines 118192 119248 +1056
Branches 37797 38581 +784
==========================================
+ Hits 18047 18196 +149
- Misses 79595 80413 +818
- Partials 20550 20639 +89
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feasible -> infeasible?
Signed-off-by: satoshi-ota <[email protected]>
…oundation#5558) * fix(avoidance): fix wrong reason for unavoidable situation Signed-off-by: satoshi-ota <[email protected]> * fix(avoidance): fix misreading variable name Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
…oundation#5558) * fix(avoidance): fix wrong reason for unavoidable situation Signed-off-by: satoshi-ota <[email protected]> * fix(avoidance): fix misreading variable name Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
Description
🤖 Generated by Copilot at e3b0b0b
Refactored the avoidance module in
behavior_path_planner
to improve performance and readability. Fixed a wrong value forobject.reason
inavoidance_module.cpp
.If the vehicle can't avoid object because of
INSUFFICIENT_LATERAL_MARGIN
, the avoidance module do nothing in unsafe condition. On the other hand, the reason isTOO_LARGE_JERK
, the vehicle stops in front of the object with keeping enough margin to avoid.Before this PR, sometimes module set wrong unavoidable reason even if there is enough space.
Tests performed
Effects on system behavior
Nothing.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.