Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(avoidance): fix wrong reason for unavoidable situation #5558

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Nov 13, 2023

Description

🤖 Generated by Copilot at e3b0b0b

Refactored the avoidance module in behavior_path_planner to improve performance and readability. Fixed a wrong value for object.reason in avoidance_module.cpp.


If the vehicle can't avoid object because of INSUFFICIENT_LATERAL_MARGIN, the avoidance module do nothing in unsafe condition. On the other hand, the reason is TOO_LARGE_JERK, the vehicle stops in front of the object with keeping enough margin to avoid.

Before this PR, sometimes module set wrong unavoidable reason even if there is enough space.

Tests performed

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 13, 2023
@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 13, 2023
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (d749a7d) 15.26% compared to head (cc6d66a) 15.25%.
Report is 31 commits behind head on main.

Files Patch % Lines
...er/src/scene_module/avoidance/avoidance_module.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5558      +/-   ##
==========================================
- Coverage   15.26%   15.25%   -0.02%     
==========================================
  Files        1713     1713              
  Lines      118192   119248    +1056     
  Branches    37797    38581     +784     
==========================================
+ Hits        18047    18196     +149     
- Misses      79595    80413     +818     
- Partials    20550    20639      +89     
Flag Coverage Δ *Carryforward flag
differential 12.70% <0.00%> (?)
total 15.27% <ø> (+<0.01%) ⬆️ Carriedforward from e3b0b0b

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rej55 rej55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feasible -> infeasible?

@satoshi-ota satoshi-ota requested a review from rej55 November 16, 2023 06:12
@satoshi-ota satoshi-ota enabled auto-merge (squash) November 16, 2023 06:26
@satoshi-ota satoshi-ota merged commit e28a501 into autowarefoundation:main Nov 16, 2023
24 of 27 checks passed
@satoshi-ota satoshi-ota deleted the fix/avoidance-wrong-reason branch November 16, 2023 06:45
satoshi-ota added a commit to satoshi-ota/autoware.universe that referenced this pull request Nov 21, 2023
…oundation#5558)

* fix(avoidance): fix wrong reason for unavoidable situation

Signed-off-by: satoshi-ota <[email protected]>

* fix(avoidance): fix misreading variable name

Signed-off-by: satoshi-ota <[email protected]>

---------

Signed-off-by: satoshi-ota <[email protected]>
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Nov 22, 2023
…oundation#5558)

* fix(avoidance): fix wrong reason for unavoidable situation

Signed-off-by: satoshi-ota <[email protected]>

* fix(avoidance): fix misreading variable name

Signed-off-by: satoshi-ota <[email protected]>

---------

Signed-off-by: satoshi-ota <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants