-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(avoidance): fix bug in shift lon distance calculation #5557
Merged
satoshi-ota
merged 3 commits into
autowarefoundation:main
from
satoshi-ota:fix/avoidance-prepare-phase
Nov 16, 2023
Merged
fix(avoidance): fix bug in shift lon distance calculation #5557
satoshi-ota
merged 3 commits into
autowarefoundation:main
from
satoshi-ota:fix/avoidance-prepare-phase
Nov 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
Nov 12, 2023
satoshi-ota
force-pushed
the
fix/avoidance-prepare-phase
branch
from
November 12, 2023 23:25
4ee3ffd
to
fb4fe8b
Compare
satoshi-ota
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Nov 12, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5557 +/- ##
==========================================
+ Coverage 15.32% 15.33% +0.01%
==========================================
Files 1721 1721
Lines 118559 118477 -82
Branches 37995 37980 -15
==========================================
+ Hits 18169 18170 +1
+ Misses 79657 79568 -89
- Partials 20733 20739 +6
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
satoshi-ota
force-pushed
the
fix/avoidance-prepare-phase
branch
from
November 15, 2023 10:10
fb4fe8b
to
136b0d7
Compare
satoshi-ota
requested review from
rej55,
kosuke55,
kyoichi-sugahara,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
tkimura4,
purewater0901 and
zulfaqar-azmi-t4
as code owners
November 15, 2023 10:15
satoshi-ota
force-pushed
the
fix/avoidance-prepare-phase
branch
from
November 16, 2023 06:42
136b0d7
to
ddeeb96
Compare
rej55
approved these changes
Nov 16, 2023
Signed-off-by: satoshi-ota <[email protected]>
Signed-off-by: satoshi-ota <[email protected]>
Signed-off-by: satoshi-ota <[email protected]>
satoshi-ota
force-pushed
the
fix/avoidance-prepare-phase
branch
from
November 16, 2023 06:47
ddeeb96
to
c7532b8
Compare
satoshi-ota
added a commit
to satoshi-ota/autoware.universe
that referenced
this pull request
Nov 21, 2023
…undation#5557) * fix(avoidance): consider avoidance prepare time Signed-off-by: satoshi-ota <[email protected]> * fix(avoidance): consider avoidance prepare distance Signed-off-by: satoshi-ota <[email protected]> * fix(avoidance): use std::optional Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
takayuki5168
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Nov 22, 2023
…undation#5557) * fix(avoidance): consider avoidance prepare time Signed-off-by: satoshi-ota <[email protected]> * fix(avoidance): consider avoidance prepare distance Signed-off-by: satoshi-ota <[email protected]> * fix(avoidance): use std::optional Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🤖 Generated by Copilot at 4ee3ffd
This pull request modifies the
avoidance
scene module of thebehavior_path_planner
package to enhance the obstacle avoidance logic. It changes how the lateral shift profile and the forward detection range are computed for each object, taking into account the avoidance distance and the nominal prepare distance. These changes aim to improve the feasibility, priority, and safety of the avoidance path candidates.Tests performed
Effects on system behavior
Improve avoidance behavior.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.