Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(avoidance): fix bug in shift lon distance calculation #5557

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Nov 12, 2023

Description

🤖 Generated by Copilot at 4ee3ffd

This pull request modifies the avoidance scene module of the behavior_path_planner package to enhance the obstacle avoidance logic. It changes how the lateral shift profile and the forward detection range are computed for each object, taking into account the avoidance distance and the nominal prepare distance. These changes aim to improve the feasibility, priority, and safety of the avoidance path candidates.

Tests performed

Effects on system behavior

Improve avoidance behavior.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 12, 2023
@satoshi-ota satoshi-ota force-pushed the fix/avoidance-prepare-phase branch from 4ee3ffd to fb4fe8b Compare November 12, 2023 23:25
@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 12, 2023
Copy link

codecov bot commented Nov 12, 2023

Codecov Report

Attention: 83 lines in your changes are missing coverage. Please review.

Comparison is base (765a596) 15.32% compared to head (c7532b8) 15.33%.
Report is 14 commits behind head on main.

Files Patch % Lines
.../scene_module/goal_planner/goal_planner_module.cpp 2.50% 39 Missing ⚠️
...er/src/scene_module/avoidance/avoidance_module.cpp 0.00% 24 Missing ⚠️
.../scene_module/goal_planner/goal_planner_module.hpp 0.00% 15 Missing ⚠️
...rivable_area_expansion/drivable_area_expansion.cpp 40.00% 0 Missing and 3 partials ⚠️
...e/behavior_path_planner/utils/avoidance/helper.hpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5557      +/-   ##
==========================================
+ Coverage   15.32%   15.33%   +0.01%     
==========================================
  Files        1721     1721              
  Lines      118559   118477      -82     
  Branches    37995    37980      -15     
==========================================
+ Hits        18169    18170       +1     
+ Misses      79657    79568      -89     
- Partials    20733    20739       +6     
Flag Coverage Δ *Carryforward flag
differential 12.70% <3.48%> (?)
total 15.34% <40.00%> (+0.01%) ⬆️ Carriedforward from 017aed4

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@satoshi-ota satoshi-ota force-pushed the fix/avoidance-prepare-phase branch from ddeeb96 to c7532b8 Compare November 16, 2023 06:47
@satoshi-ota satoshi-ota merged commit 6bfd079 into autowarefoundation:main Nov 16, 2023
20 of 23 checks passed
@satoshi-ota satoshi-ota deleted the fix/avoidance-prepare-phase branch November 16, 2023 08:10
satoshi-ota added a commit to satoshi-ota/autoware.universe that referenced this pull request Nov 21, 2023
…undation#5557)

* fix(avoidance): consider avoidance prepare time

Signed-off-by: satoshi-ota <[email protected]>

* fix(avoidance): consider avoidance prepare distance

Signed-off-by: satoshi-ota <[email protected]>

* fix(avoidance): use std::optional

Signed-off-by: satoshi-ota <[email protected]>

---------

Signed-off-by: satoshi-ota <[email protected]>
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Nov 22, 2023
…undation#5557)

* fix(avoidance): consider avoidance prepare time

Signed-off-by: satoshi-ota <[email protected]>

* fix(avoidance): consider avoidance prepare distance

Signed-off-by: satoshi-ota <[email protected]>

* fix(avoidance): use std::optional

Signed-off-by: satoshi-ota <[email protected]>

---------

Signed-off-by: satoshi-ota <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants