-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(geo_pose_projector): use geo_pose_projector in eagleye #5513
feat(geo_pose_projector): use geo_pose_projector in eagleye #5513
Conversation
Signed-off-by: kminoda <[email protected]>
Signed-off-by: kminoda <[email protected]>
Signed-off-by: kminoda <[email protected]>
Signed-off-by: kminoda <[email protected]>
Signed-off-by: kminoda <[email protected]>
Signed-off-by: kminoda <[email protected]>
Signed-off-by: kminoda <[email protected]>
Signed-off-by: kminoda <[email protected]>
Signed-off-by: kminoda <[email protected]>
Signed-off-by: kminoda <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5513 +/- ##
==========================================
- Coverage 15.37% 14.79% -0.58%
==========================================
Files 1697 1686 -11
Lines 117496 116750 -746
Branches 37763 36189 -1574
==========================================
- Hits 18063 17274 -789
- Misses 78861 79976 +1115
+ Partials 20572 19500 -1072
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
@kminoda I think that this PR would resolve this issue? Is that correct? |
Signed-off-by: kminoda <[email protected]>
…foundation#5513) * feat(tier4_geo_pose_projector): use tier4_geo_pose_projector in eagleye Signed-off-by: kminoda <[email protected]> * style(pre-commit): autofix * fix(eagleye): split fix2pose Signed-off-by: kminoda <[email protected]> * style(pre-commit): autofix * fix name: fuser -> fusion Signed-off-by: kminoda <[email protected]> * style(pre-commit): autofix * update Signed-off-by: kminoda <[email protected]> * style(pre-commit): autofix * update readme Signed-off-by: kminoda <[email protected]> * style(pre-commit): autofix * add #include <string> Signed-off-by: kminoda <[email protected]> * add rclcpp in dependency Signed-off-by: kminoda <[email protected]> * style(pre-commit): autofix * add limitation in readme Signed-off-by: kminoda <[email protected]> * style(pre-commit): autofix * update tier4_localization_launch Signed-off-by: kminoda <[email protected]> * update tier4_localization_launch Signed-off-by: kminoda <[email protected]> * rename package Signed-off-by: kminoda <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: kminoda <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Description
Since current Eagleye implementation does not align with the
/map/map_projector_info
, I would like to propose the following modificationtier4_geo_pose_projector
that, given a georeferenced pose and the projector info, converts and publishes the posegeo_pose_converter
from Eagleye repositoryNote that the new package will be added to autoware.universe instead of Eagleye repository, since it is dependent on Autoware's component interface and may be used to other applications as well.
Tests performed
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.