Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(geo_pose_projector): use geo_pose_projector in eagleye #5513

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Nov 7, 2023

Description

Since current Eagleye implementation does not align with the /map/map_projector_info, I would like to propose the following modification

  • Adding a new package tier4_geo_pose_projector that, given a georeferenced pose and the projector info, converts and publishes the pose
  • Use this in Eagleye instead of geo_pose_converter from Eagleye repository

Note that the new package will be added to autoware.universe instead of Eagleye repository, since it is dependent on Autoware's component interface and may be used to other applications as well.

Tests performed

  • Confirmed that, using logging_simulator, eagleye works with sample map from shinjuku AWSIM data
  • Confirmed that, using logging_simulator and the following map_projector_info.yaml, eagleye works with sample map from shinjuku AWSIM data
projector_type: TransverseMercator
vertical_datum: WGS84
map_origin:
  latitude: 35.61836750154
  longitude: 139.78066608243
  altitude: 2.0

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:localization Vehicle's position determination in its environment. (auto-assigned) label Nov 7, 2023
@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Nov 7, 2023
@kminoda kminoda added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 7, 2023
Signed-off-by: kminoda <[email protected]>
@github-actions github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label Nov 7, 2023
@kminoda kminoda marked this pull request as ready for review November 8, 2023 00:38
@kminoda kminoda marked this pull request as draft November 8, 2023 00:41
@kminoda kminoda marked this pull request as ready for review November 8, 2023 00:46
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Attention: 40 lines in your changes are missing coverage. Please review.

Comparison is base (0e471b3) 15.37% compared to head (d723e62) 14.79%.
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5513      +/-   ##
==========================================
- Coverage   15.37%   14.79%   -0.58%     
==========================================
  Files        1697     1686      -11     
  Lines      117496   116750     -746     
  Branches    37763    36189    -1574     
==========================================
- Hits        18063    17274     -789     
- Misses      78861    79976    +1115     
+ Partials    20572    19500    -1072     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 14.80% <ø> (-0.58%) ⬇️ Carriedforward from 3199839

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...geo_pose_projector/src/geo_pose_projector_node.cpp 0.00% <0.00%> (ø)
...tion/geo_pose_projector/src/geo_pose_projector.cpp 0.00% <0.00%> (ø)

... and 85 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YamatoAndo
Copy link
Contributor

@kminoda I think that this PR would resolve this issue? Is that correct?

@kminoda kminoda merged commit 2a697c2 into autowarefoundation:main Nov 13, 2023
20 of 24 checks passed
@kminoda kminoda deleted the feat/eagleye/use_tier4_geo_pose_projector branch November 13, 2023 04:16
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Nov 22, 2023
…foundation#5513)

* feat(tier4_geo_pose_projector): use tier4_geo_pose_projector in eagleye

Signed-off-by: kminoda <[email protected]>

* style(pre-commit): autofix

* fix(eagleye): split fix2pose

Signed-off-by: kminoda <[email protected]>

* style(pre-commit): autofix

* fix name: fuser -> fusion

Signed-off-by: kminoda <[email protected]>

* style(pre-commit): autofix

* update

Signed-off-by: kminoda <[email protected]>

* style(pre-commit): autofix

* update readme

Signed-off-by: kminoda <[email protected]>

* style(pre-commit): autofix

* add #include <string>

Signed-off-by: kminoda <[email protected]>

* add rclcpp in dependency

Signed-off-by: kminoda <[email protected]>

* style(pre-commit): autofix

* add limitation in readme

Signed-off-by: kminoda <[email protected]>

* style(pre-commit): autofix

* update tier4_localization_launch

Signed-off-by: kminoda <[email protected]>

* update tier4_localization_launch

Signed-off-by: kminoda <[email protected]>

* rename package

Signed-off-by: kminoda <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: kminoda <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants