-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sampling_based_planner): fix runtime error #5490
fix(sampling_based_planner): fix runtime error #5490
Conversation
Signed-off-by: satoshi-ota <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5490 +/- ##
==========================================
- Coverage 14.86% 14.85% -0.01%
==========================================
Files 1666 1669 +3
Lines 116258 116318 +60
Branches 36266 36266
==========================================
Hits 17277 17277
- Misses 79476 79535 +59
- Partials 19505 19506 +1
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and there is no issue 👍
Signed-off-by: satoshi-ota <[email protected]>
Description
🤖 Generated by Copilot at d6d8eb1
Refactor
PathSampler
class by moving sampling functions tobezier_sampling.hpp
and add Eigen library dependency. This improves code organization and reusability and enables linear algebra operations for bezier curves.Tests performed
Psim
Effects on system behavior
Nothing.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.