Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sampling_based_planner): fix runtime error #5490

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Nov 6, 2023

Description

🤖 Generated by Copilot at d6d8eb1

Refactor PathSampler class by moving sampling functions to bezier_sampling.hpp and add Eigen library dependency. This improves code organization and reusability and enables linear algebra operations for bezier curves.

[component_container_mt-30] /opt/ros/humble/lib/rclcpp_components/component_container_mt: symbol lookup error: /home/satoshi/pilot-auto/install/path_sampler/lib/libpath_sampler.so: undefined symbol: _ZN12path_sampler11PathSampler12copyVelocityERKSt6vectorIN27autoware_auto_planning_msgs3msg16TrajectoryPoint_ISaIvEEESaIS6_EERS8_RKN13geometry_msgs3msg5Pose_IS5_EE

Tests performed

Psim

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 6, 2023
Copy link
Contributor

@rej55 rej55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 13, 2023
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (ee20545) 14.86% compared to head (d6d8eb1) 14.85%.
Report is 48 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5490      +/-   ##
==========================================
- Coverage   14.86%   14.85%   -0.01%     
==========================================
  Files        1666     1669       +3     
  Lines      116258   116318      +60     
  Branches    36266    36266              
==========================================
  Hits        17277    17277              
- Misses      79476    79535      +59     
- Partials    19505    19506       +1     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 14.85% <0.00%> (-0.01%) ⬇️ Carriedforward from e628971

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...g/sampling_based_planner/path_sampler/src/node.cpp 0.00% <0.00%> (ø)
...nclude/planning_topic_converter/converter_base.hpp 0.00% <0.00%> (ø)
...lanning_topic_converter/src/path_to_trajectory.cpp 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@maxime-clem maxime-clem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and there is no issue 👍

@satoshi-ota satoshi-ota merged commit 88b06e0 into autowarefoundation:main Nov 13, 2023
39 of 45 checks passed
@satoshi-ota satoshi-ota deleted the fix/undefind-symbol branch November 13, 2023 08:58
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants