Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(sync-files): add mkdocs_macros module #5475

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Conversation

xmfcx
Copy link
Contributor

@xmfcx xmfcx commented Nov 2, 2023

Description

Related PRs (reverse chronological order):

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@xmfcx xmfcx self-assigned this Nov 2, 2023
@github-actions github-actions bot added the type:ci Continuous Integration (CI) processes and testing. (auto-assigned) label Nov 2, 2023
@xmfcx xmfcx force-pushed the ci/add-mk-docs-module branch from 86f9024 to 78db446 Compare November 2, 2023 15:31
@xmfcx
Copy link
Contributor Author

xmfcx commented Nov 2, 2023

It seems to be working, @mitsudome-r could you review this please?

This blocks my other PR:

@xmfcx xmfcx requested a review from mitsudome-r November 2, 2023 15:44
@xmfcx xmfcx enabled auto-merge (squash) November 2, 2023 15:44
@xmfcx xmfcx added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 2, 2023
Copy link
Member

@mitsudome-r mitsudome-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@xmfcx xmfcx merged commit fc5e41f into main Nov 2, 2023
29 checks passed
@xmfcx xmfcx deleted the ci/add-mk-docs-module branch November 2, 2023 16:05
@xmfcx
Copy link
Contributor Author

xmfcx commented Nov 2, 2023

Thanks for the quick review ❤️‍🔥

kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants