-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(goal_planner): calculate stop pose from closest goal candidate #5410
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5410 +/- ##
==========================================
+ Coverage 14.75% 15.09% +0.33%
==========================================
Files 1661 1661
Lines 115526 115549 +23
Branches 35669 35685 +16
==========================================
+ Hits 17049 17443 +394
+ Misses 79232 78589 -643
- Partials 19245 19517 +272
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
planning/behavior_path_planner/src/utils/goal_planner/goal_searcher.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
planning/behavior_path_planner/src/utils/goal_planner/goal_searcher.cpp
Outdated
Show resolved
Hide resolved
planning/behavior_path_planner/src/scene_module/goal_planner/goal_planner_module.cpp
Show resolved
Hide resolved
Signed-off-by: kosuke55 <[email protected]>
…rcher.cpp Co-authored-by: Kyoichi Sugahara <[email protected]>
9b5579a
to
0e3681f
Compare
Description
currently the stop pose when path is not found is caculated from goal search start pose.
this include invalid goal pose like in no_parking_lane and stop too far.
In this PR, calculate stop pose from actual goal candidates which do not include no_parking_lane goal.
before
after
Related links
this may solve degradation of #5371 (comment)
Tests performed
psim
evaluator_description: feat/goal_planner_stop_pose
2023/10/25 https://evaluation.tier4.jp/evaluation/reports/8bfda284-da50-5c03-ac67-a2f834d6c731/?project_id=prd_jt
evaluator_description: feat/goal_planner_stop_pose
2023/10/26 https://evaluation.tier4.jp/evaluation/reports/04de2c84-3b7f-5299-b0b1-9eb0d98f6721/?project_id=prd_jt
Notes for reviewers
Interface changes
none
Effects on system behavior
none
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.