-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(avoidance): suppress unnecessary avoidance path #5387
Merged
satoshi-ota
merged 2 commits into
autowarefoundation:main
from
satoshi-ota:feat/filter-object-intersection
Nov 24, 2023
Merged
feat(avoidance): suppress unnecessary avoidance path #5387
satoshi-ota
merged 2 commits into
autowarefoundation:main
from
satoshi-ota:feat/filter-object-intersection
Nov 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
Oct 24, 2023
satoshi-ota
force-pushed
the
feat/filter-object-intersection
branch
3 times, most recently
from
October 30, 2023 12:41
ec94924
to
614aeee
Compare
satoshi-ota
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Oct 30, 2023
satoshi-ota
force-pushed
the
feat/filter-object-intersection
branch
from
October 31, 2023 23:29
614aeee
to
c9ae8ef
Compare
4 tasks
satoshi-ota
force-pushed
the
feat/filter-object-intersection
branch
from
November 15, 2023 09:49
c9ae8ef
to
31298b6
Compare
satoshi-ota
requested review from
rej55,
kosuke55,
kyoichi-sugahara,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
tkimura4,
purewater0901 and
zulfaqar-azmi-t4
as code owners
November 15, 2023 09:53
satoshi-ota
force-pushed
the
feat/filter-object-intersection
branch
from
November 16, 2023 14:36
31298b6
to
fce8c9f
Compare
github-actions
bot
added
the
type:documentation
Creating or refining documentation. (auto-assigned)
label
Nov 16, 2023
satoshi-ota
force-pushed
the
feat/filter-object-intersection
branch
3 times, most recently
from
November 18, 2023 09:26
352d152
to
94b6aff
Compare
satoshi-ota
added
the
run:deploy-docs
Mark for deploy-docs action generation. (used-by-ci)
label
Nov 20, 2023
satoshi-ota
added a commit
to satoshi-ota/autoware.universe
that referenced
this pull request
Nov 21, 2023
…undation#5387 Signed-off-by: satoshi-ota <[email protected]>
satoshi-ota
force-pushed
the
feat/filter-object-intersection
branch
from
November 21, 2023 10:18
2525ffb
to
354aa32
Compare
Signed-off-by: satoshi-ota <[email protected]>
satoshi-ota
force-pushed
the
feat/filter-object-intersection
branch
from
November 24, 2023 06:50
354aa32
to
cbb0012
Compare
TODO: Write documentation about object filtering policy. @satoshi-ota |
Signed-off-by: satoshi-ota <[email protected]>
satoshi-ota
force-pushed
the
feat/filter-object-intersection
branch
from
November 24, 2023 07:40
0c9f38e
to
0502050
Compare
rej55
approved these changes
Nov 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
danielsanchezaran
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Dec 15, 2023
…ion#5387) * docs(avoidance): update flowchart Signed-off-by: satoshi-ota <[email protected]> * feat(avoidance): suppress unnecessary avoidance path Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
run:deploy-docs
Mark for deploy-docs action generation. (used-by-ci)
type:documentation
Creating or refining documentation. (auto-assigned)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🤖 Generated by Copilot at 806fcd3
This pull request refactors and improves the
filterTargetObjects
function inplanning/behavior_path_planner/src/utils/avoidance/utils.cpp
by extracting some logic into separate functions and using utility functions fromtier4_autoware_utils/math/unit_conversion.hpp
. It also adds two new functions,isParkedOnRoadShoulder
andtoPolygon2d
, inplanning/behavior_path_planner/include/behavior_path_planner/utils/utils.hpp
andplanning/behavior_path_planner/src/utils/utils.cpp
, to check if an object is parked on the road shoulder and to convert lanelet polygons to boost geometry polygons. These changes aim to simplify the code and improve readability, maintainability, and performance.Please review following PR at first:
autowarefoundation/autoware_launch#668
Tests performed
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.