Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(avoidance): suppress unnecessary avoidance path #5387

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Oct 24, 2023

Description

🤖 Generated by Copilot at 806fcd3

This pull request refactors and improves the filterTargetObjects function in planning/behavior_path_planner/src/utils/avoidance/utils.cpp by extracting some logic into separate functions and using utility functions from tier4_autoware_utils/math/unit_conversion.hpp. It also adds two new functions, isParkedOnRoadShoulder and toPolygon2d, in planning/behavior_path_planner/include/behavior_path_planner/utils/utils.hpp and planning/behavior_path_planner/src/utils/utils.cpp, to check if an object is parked on the road shoulder and to convert lanelet polygons to boost geometry polygons. These changes aim to simplify the code and improve readability, maintainability, and performance.

Please review following PR at first:
autowarefoundation/autoware_launch#668


image

image

image

Tests performed

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Oct 24, 2023
@satoshi-ota satoshi-ota force-pushed the feat/filter-object-intersection branch 3 times, most recently from ec94924 to 614aeee Compare October 30, 2023 12:41
@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 30, 2023
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Attention: 1237 lines in your changes are missing coverage. Please review.

Comparison is base (765a596) 15.32% compared to head (0502050) 12.62%.
Report is 56 commits behind head on main.

Files Patch % Lines
...s/drivable_area_expansion/static_drivable_area.cpp 11.54% 623 Missing and 74 partials ⚠️
...ehavior_path_planner/src/utils/avoidance/utils.cpp 4.27% 169 Missing and 10 partials ⚠️
.../scene_module/goal_planner/goal_planner_module.cpp 1.48% 132 Missing and 1 partial ⚠️
...cene_module/start_planner/start_planner_module.cpp 7.27% 51 Missing ⚠️
planning/behavior_path_planner/src/utils/utils.cpp 35.89% 31 Missing and 19 partials ⚠️
...er/src/scene_module/avoidance/avoidance_module.cpp 2.43% 38 Missing and 2 partials ⚠️
...ing/behavior_path_planner/src/utils/path_utils.cpp 42.30% 0 Missing and 30 partials ⚠️
.../scene_module/goal_planner/goal_planner_module.hpp 15.78% 15 Missing and 1 partial ⚠️
...th_planner/src/scene_module/lane_change/normal.cpp 0.00% 14 Missing ⚠️
...ner/src/utils/path_safety_checker/safety_check.cpp 0.00% 7 Missing ⚠️
... and 8 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5387       +/-   ##
===========================================
- Coverage   15.32%   12.62%    -2.71%     
===========================================
  Files        1721      107     -1614     
  Lines      118559    14997   -103562     
  Branches    37995     8404    -29591     
===========================================
- Hits        18169     1893    -16276     
+ Misses      79657    10156    -69501     
+ Partials    20733     2948    -17785     
Flag Coverage Δ
differential 12.62% <11.70%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@satoshi-ota satoshi-ota force-pushed the feat/filter-object-intersection branch from 614aeee to c9ae8ef Compare October 31, 2023 23:29
@satoshi-ota satoshi-ota force-pushed the feat/filter-object-intersection branch from c9ae8ef to 31298b6 Compare November 15, 2023 09:49
@satoshi-ota satoshi-ota marked this pull request as ready for review November 15, 2023 09:53
@satoshi-ota satoshi-ota force-pushed the feat/filter-object-intersection branch from 31298b6 to fce8c9f Compare November 16, 2023 14:36
@github-actions github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label Nov 16, 2023
@satoshi-ota satoshi-ota force-pushed the feat/filter-object-intersection branch 3 times, most recently from 352d152 to 94b6aff Compare November 18, 2023 09:26
@satoshi-ota satoshi-ota added the run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Nov 20, 2023
satoshi-ota added a commit to satoshi-ota/autoware.universe that referenced this pull request Nov 21, 2023
@satoshi-ota satoshi-ota force-pushed the feat/filter-object-intersection branch from 2525ffb to 354aa32 Compare November 21, 2023 10:18
@satoshi-ota satoshi-ota force-pushed the feat/filter-object-intersection branch from 354aa32 to cbb0012 Compare November 24, 2023 06:50
@satoshi-ota
Copy link
Contributor Author

TODO: Write documentation about object filtering policy. @satoshi-ota

@satoshi-ota satoshi-ota force-pushed the feat/filter-object-intersection branch from 0c9f38e to 0502050 Compare November 24, 2023 07:40
Copy link
Contributor

@rej55 rej55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota merged commit 9a5e5c4 into autowarefoundation:main Nov 24, 2023
19 of 23 checks passed
@satoshi-ota satoshi-ota deleted the feat/filter-object-intersection branch November 24, 2023 10:12
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Dec 15, 2023
…ion#5387)

* docs(avoidance): update flowchart

Signed-off-by: satoshi-ota <[email protected]>

* feat(avoidance): suppress unnecessary avoidance path

Signed-off-by: satoshi-ota <[email protected]>

---------

Signed-off-by: satoshi-ota <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants