fix(goal_planner): use recursive mutex instead of transaction

[kosuke55]

This reverts commit 654fa8c in #5202

Description

transaction cannot lock in the following cases

• thread1: use transaction
• thread2: use just setter/getter

Related links

#5202

Tests performed

psim

evaluator_description: fix/goal_planner_recursive_mutex
2023/10/23 https://evaluation.tier4.jp/evaluation/reports/fee28b13-55cd-5606-882e-b5c476037840/?project_id=prd_jt

Notes for reviewers

Interface changes

none

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.
• The PR has been properly tested.
• The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.
• The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

[kyoichi-sugahara]

@kosuke55
LGMT!Thanks!
Please merge this after checking degression test just in case.

[codecov]

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (69813cb) 14.76% compared to head (e37bd12) 14.81%.
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5379      +/-   ##
==========================================
+ Coverage   14.76%   14.81%   +0.04%     
==========================================
  Files        1662     1662              
  Lines      115457   115439      -18     
  Branches    35639    35647       +8     
==========================================
+ Hits        17047    17097      +50     
+ Misses      79181    79077     -104     
- Partials    19229    19265      +36     

Flag	Coverage Δ		*Carryforward flag
differential	12.67% <19.35%> (?)
total	14.76% <ø> (+<0.01%)	⬆️	Carriedforward from 386b627

*This pull request uses carry forward flags. Click here to find out more.

Files	Coverage Δ
.../scene_module/goal_planner/goal_planner_module.hpp	28.84% <66.66%> (+4.28%)	⬆️
.../scene_module/goal_planner/goal_planner_module.cpp	5.34% <14.28%> (+0.16%)	⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kosuke55]

compare
https://evaluation.tier4.jp/evaluation/reports/tables/new?catalog_id=cb497016-2e2f-4ce0-9ac8-68d77a27a55d&filter=&job_id=fee28b13-55cd-5606-882e-b5c476037840&project_id=prd_jt&table_config=date%2Ctotal%2Csrc%2Chide&target_ids=8cdcf567-81a6-59db-81f7-f533153b3e57