Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not use c++20 char8_t keyword #3629

Merged
merged 1 commit into from
May 6, 2024
Merged

fix: do not use c++20 char8_t keyword #3629

merged 1 commit into from
May 6, 2024

Conversation

ralwing
Copy link
Contributor

@ralwing ralwing commented May 5, 2023

Description

from C++ 20 char8_t is a restricted keyword:
https://en.cppreference.com/w/cpp/keyword/char8_t

Tests performed

Not applicable.

Effects on system behavior

Error when compiling with -std=c++20

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@ralwing ralwing requested a review from a team as a code owner May 5, 2023 13:53
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label May 5, 2023
@ralwing ralwing force-pushed the cpp-20-compatybility branch from 30bb04f to 9246ea0 Compare May 5, 2023 13:54
@ralwing ralwing changed the title do not use c++20 char8_t keyword fix do not use c++20 char8_t keyword May 5, 2023
@ralwing ralwing changed the title fix do not use c++20 char8_t keyword fix: do not use c++20 char8_t keyword May 5, 2023
@ralwing ralwing force-pushed the cpp-20-compatybility branch 4 times, most recently from a5561ff to 34d0141 Compare May 8, 2023 07:23
@ralwing ralwing force-pushed the cpp-20-compatybility branch from 34d0141 to 90e3e2c Compare May 16, 2023 19:33
@ralwing
Copy link
Contributor Author

ralwing commented Jun 13, 2023

@mitsudome-r Kind reminder for merging this simple fix.

@mitsudome-r mitsudome-r enabled auto-merge (squash) June 13, 2023 07:35
@mitsudome-r
Copy link
Member

@ralwing Thanks.
I have updated the branch and enabled auto-merge. It should merge automatically when all required checks pass in the CI.

@codecov
Copy link

codecov bot commented Jun 13, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 14.90%. Comparing base (b307b3d) to head (843a1e9).
Report is 1 commits behind head on main.

❗ Current head 843a1e9 differs from pull request most recent head ba45c06. Consider uploading reports for the commit ba45c06 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3629      +/-   ##
==========================================
- Coverage   14.96%   14.90%   -0.07%     
==========================================
  Files        1967     1499     -468     
  Lines      135953   117796   -18157     
  Branches    40556    39130    -1426     
==========================================
- Hits        20352    17561    -2791     
+ Misses      92946    81333   -11613     
+ Partials    22655    18902    -3753
Flag Coverage Δ *Carryforward flag
differential 18.00% <ø> (?)
total 14.42% <ø> (-0.55%) ⬇️ Carriedforward from 46b6f36

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ralwing
Copy link
Contributor Author

ralwing commented Jun 16, 2023

@mitsudome-r Seems like the Code owner review is required to be merged?

@stale
Copy link

stale bot commented Aug 15, 2023

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Aug 15, 2023
@ralwing
Copy link
Contributor Author

ralwing commented Aug 16, 2023

@mitsudome-r I kindly ask for merging this.

@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Aug 16, 2023
@yukkysaito yukkysaito added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 21, 2023
@stale Stale
Copy link

stale bot commented Nov 20, 2023

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Nov 20, 2023
auto-merge was automatically disabled May 6, 2024 12:29

Head branch was pushed to by a user without write access

@ralwing ralwing force-pushed the cpp-20-compatybility branch from 843a1e9 to ba45c06 Compare May 6, 2024 12:29
@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label May 6, 2024
@shmpwk shmpwk enabled auto-merge (squash) May 6, 2024 12:40
@shmpwk shmpwk merged commit ebe360d into autowarefoundation:main May 6, 2024
23 of 24 checks passed
vividf pushed a commit to vividf/autoware.universe that referenced this pull request May 16, 2024
@ralwing @vividf
fix: do not use c++20 char8_t keyword (autowarefoundation#3629)
5f0ae9c 
fix: do not use c++20 keyword as a type alias

Signed-off-by: Grzegorz Głowacki <[email protected]>
Signed-off-by: vividf <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
@ralwing @karishma1911
fix: do not use c++20 char8_t keyword (autowarefoundation#3629)
b764331 
fix: do not use c++20 keyword as a type alias

Signed-off-by: Grzegorz Głowacki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitsudome-r mitsudome-r mitsudome-r approved these changes

@shmpwk shmpwk shmpwk approved these changes

@satoshi-ota satoshi-ota Awaiting requested review from satoshi-ota satoshi-ota is a code owner

@tkimura4 tkimura4 Awaiting requested review from tkimura4 tkimura4 is a code owner

Assignees
No one assigned
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ralwing @mitsudome-r @shmpwk @yukkysaito