build(tensorrt_yolox): remove download logic from CMake

[esteve]

Description

See #3137

Depends on autowarefoundation/autoware_common#164

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: -0.15% ⚠️

Comparison is base (0f441c1) 15.75% compared to head (99e526e) 15.61%.
Report is 7 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3143      +/-   ##
==========================================
- Coverage   15.75%   15.61%   -0.15%     
==========================================
  Files        1581     1587       +6     
  Lines      109651   110639     +988     
  Branches    34291    34289       -2     
==========================================
  Hits        17273    17273              
- Misses      73344    74333     +989     
+ Partials    19034    19033       -1     

Flag	Coverage Δ		*Carryforward flag
differential	0.00% <ø> (?)
total	15.75% <ø> (+<0.01%)	⬆️	Carriedforward from 0f441c1

*This pull request uses carry forward flags. Click here to find out more.

Files Changed	Coverage Δ
...calizer/include/ekf_localizer/hyper_parameters.hpp	0.00% <ø> (ø)
localization/ekf_localizer/src/ekf_localizer.cpp	0.00% <ø> (ø)
...can_matcher/include/ndt_scan_matcher/util_func.hpp	0.00% <ø> (ø)
...ion/ndt_scan_matcher/src/ndt_scan_matcher_core.cpp	0.00% <ø> (ø)
localization/ndt_scan_matcher/src/util_func.cpp	0.00% <ø> (ø)
localization/stop_filter/src/stop_filter.cpp	0.00% <ø> (ø)
...gs_adapter/src/autoware_auto_msgs_adapter_core.cpp	47.82% <ø> (ø)
...dapter/test/test_msg_ackermann_control_command.cpp	34.00% <ø> (+0.66%)	⬆️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[stale]

This pull request has been automatically marked as stale because it has not had recent activity.

[esteve]

@xmfcx @mitsudome-r this PR is now ready for review

[manato]

@esteve
Thank you for the proposal. The code modification itself makes sense to me. Actually, I'm not familiar with the background of this topic, therefore, I'd appreciated it if you answered my question: If this PR is merged, which process will download the models, especially for general autoware users?

[esteve]

@manato thanks for your feedback. The download of models will be moved to ansible scripts (see autowarefoundation/autoware#3375) and also documented for those users who want to do it manually (see autowarefoundation/autoware-documentation#345)

[manato]

@esteve I understood. Thank you for your explanation. One more question: Is there any default directory where the models are downloaded? (I could not find out it as long as I checked the PRs you kindly shared.) The launch files included in this tensorrt_yolox package expect an argument named model_path, which represent a directory path that contains ONNX (and label) files. If the default directory exists, changing the default value of the model_path would be nice to specify the directory.
(This launcher-related topic might be out-of-scope of this PR. If you would like to treat this launcher-related topic in another PR, let me know freely :) )

[esteve]

@manato in fact we just discussed that in the ASWG :-) We'll have a default folder where artifacts will be downloaded, but the user will be able to override in the command line or changing the launch files. I'll submit a PR with that change and I'd appreciate if I could get your feedback, thanks!

[miursh]

LGTM

[esteve]

@miursh thank you for your review, unfortunately I need approval from one of the code owners to merge this (ping @wep21 @dan-dnn @manato)

[wep21]

LGTM