build(lidar_apollo_instance_segmentation): remove download logic from CMake

[esteve]

Description

See #3137

Depends on autowarefoundation/autoware_common#164

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: -1.60% ⚠️

Comparison is base (a5cbb3a) 15.80% compared to head (4024e3e) 14.20%.
Report is 7 commits behind head on main.

❗ Current head 4024e3e differs from pull request most recent head 7970172. Consider uploading reports for the commit 7970172 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3140      +/-   ##
==========================================
- Coverage   15.80%   14.20%   -1.60%     
==========================================
  Files        1583     1597      +14     
  Lines      109822   109899      +77     
  Branches    34377    31523    -2854     
==========================================
- Hits        17352    15615    -1737     
- Misses      73362    77334    +3972     
+ Partials    19108    16950    -2158     

Flag	Coverage Δ		*Carryforward flag
differential	0.00% <ø> (?)
total	14.20% <ø> (-1.60%)	⬇️	Carriedforward from d6ba61a

*This pull request uses carry forward flags. Click here to find out more.

see 643 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[stale]

This pull request has been automatically marked as stale because it has not had recent activity.

[esteve]

@xmfcx @mitsudome-r this PR is now ready for review

[yukkysaito]

#3137
I don't think we have discussed this adequately, is that OK? 🙏

[mitsudome-r]

@esteve I thought we wanted to discuss how we support the download of the models before removing from CMake. (using ansible, bash script with documentation, etc.)

Could you make it into draft so that we don't merge it until we have alternative way of downloading the model? If we merge it right now, then people won't be able to run these nodes.

[mitsudome-r]

Relevant Discussion https://github.com/orgs/autowarefoundation/discussions/3649

[esteve]

@mitsudome-r no problem, I've made it a draft again. The downloading of the models is done via ansible (see autowarefoundation/autoware#3375) and documented if users want to do it manually (see autowarefoundation/autoware-documentation#345)

[esteve]

@yukkysaito this is now ready for review again, we've merged the Ansible and documentation PRs so users can download artifacts separately from CMake.

[yukkysaito]

LGTM