fix some cppcheck error

Signed-off-by: Zulfaqar Azmi <[email protected]>
autowarefoundation · May 10, 2024 · b5e38a9 · b5e38a9
1 parent 14d0f9c
commit b5e38a9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/planning/route_handler/test/route_parser.cpp b/planning/route_handler/test/route_parser.cpp
@@ -55,9 +55,9 @@ std::vector<LaneletPrimitive> parse_lanelet_primitives(const YAML::Node & node)
 {
   std::vector<LaneletPrimitive> primitives;
   primitives.reserve(node.size());
-  for (const auto & p : node) {
-    primitives.emplace_back(parse_lanelet_primitive(p));
-  }
+  std::transform(node.begin(), node.end(), std::back_inserter(primitives), [&](const auto & p) {
+    return parse_lanelet_primitive(p);
+  });
 
   return primitives;
 }

diff --git a/planning/route_handler/test/test_route_handler.hpp b/planning/route_handler/test/test_route_handler.hpp
@@ -40,7 +40,7 @@ using autoware_auto_mapping_msgs::msg::HADMapBin;
 class TestRouteHandler : public ::testing::Test
 {
 public:
-  TestRouteHandler() { route_handler_ = std::make_shared<RouteHandler>(makeMapBinMsg()); }
+  TestRouteHandler() : route_handler_(std::make_shared<RouteHandler>(makeMapBinMsg())) {}
   TestRouteHandler(const TestRouteHandler &) = delete;
   TestRouteHandler(TestRouteHandler &&) = delete;
   TestRouteHandler & operator=(const TestRouteHandler &) = delete;