Merge branch 'main' into feat/mrm_emergency_stop_operator/sub_by_polling

.cppcheck_suppressions

@@ -1,59 +1,40 @@
-arrayIndexThenCheck
-assignBoolToFloat
+*:*/test/*
+
 checkersReport
-constParameterPointer
 constParameterReference
-constStatement
 constVariable
-constVariablePointer
 constVariableReference
 containerOutOfBounds
+// cspell: ignore cstyle
 cstyleCast
-ctuOneDefinitionRuleViolation
-current_deleted_index
-duplicateAssignExpression
 duplicateBranch
 duplicateBreak
-duplicateCondition
-duplicateExpression
 funcArgNamesDifferent
 functionConst
 functionStatic
 invalidPointerCast
 knownConditionTrueFalse
 missingInclude
 missingIncludeSystem
-multiCondition
 noConstructor
 noExplicitConstructor
 noValidConfiguration
-obstacle_cruise_planner
 passedByValue
 preprocessorErrorDirective
-redundantAssignment
-redundantContinue
-redundantIfRemove
 redundantInitialization
-returnByReference
-selfAssignment
-shadowArgument
 shadowFunction
 shadowVariable
-stlFindInsert
 syntaxError
+// cspell: ignore uninit
 uninitMemberVar
 unknownMacro
 unmatchedSuppression
-unpreciseMathCall
 unreadVariable
-unsignedLessThanZero
 unusedFunction
-unusedScopedObject
 unusedStructMember
 unusedVariable
 useInitializationList
 useStlAlgorithm
-uselessCallsSubstr
 uselessOverride
 variableScope
 virtualCallInConstructor

.github/pull_request_template.md

@@ -0,0 +1,61 @@
+## Description
+
+## Related links
+
+**Parent Issue:**
+
+- Link
+
+<!-- ⬇️🟢
+**Private Links:**
+
+- [CompanyName internal link]()
+⬆️🟢 -->
+
+## How was this PR tested?
+
+## Notes for reviewers
+
+None.
+
+## Interface changes
+
+None.
+
+<!-- ⬇️🔴
+
+### Topic changes
+
+#### Additions and removals
+
+| Change type   | Topic Type      | Topic Name    | Message Type        | Description       |
+|:--------------|:----------------|:--------------|:--------------------|:------------------|
+| Added/Removed | Pub/Sub/Srv/Cli | `/topic_name` | `std_msgs/String`   | Topic description |
+
+#### Modifications
+
+| Version | Topic Type      | Topic Name        | Message Type        | Description       |
+|:--------|:----------------|:------------------|:--------------------|:------------------|
+| Old     | Pub/Sub/Srv/Cli | `/old_topic_name` | `sensor_msgs/Image` | Topic description |
+| New     | Pub/Sub/Srv/Cli | `/new_topic_name` | `sensor_msgs/Image` | Topic description |
+
+### ROS Parameter Changes
+
+#### Additions and removals
+
+| Change type   | Parameter Name | Type     | Default Value | Description       |
+|:--------------|:---------------|:---------|:--------------|:------------------|
+| Added/Removed | `param_name`   | `double` | `1.0`         | Param description |
+
+#### Modifications
+
+| Version | Parameter Name   | Type     | Default Value | Description       |
+|:--------|:-----------------|:---------|:--------------|:------------------|
+| Old     | `old_param_name` | `double` | `1.0`         | Param description |
+| New     | `new_param_name` | `double` | `1.0`         | Param description |
+
+🔴⬆️ -->
+
+## Effects on system behavior
+
+None.

.github/sync-files.yaml

@@ -7,9 +7,6 @@
     - source: .github/ISSUE_TEMPLATE/bug.yaml
     - source: .github/ISSUE_TEMPLATE/config.yml
     - source: .github/ISSUE_TEMPLATE/task.yaml
-    - source: .github/PULL_REQUEST_TEMPLATE.md
-    - source: .github/PULL_REQUEST_TEMPLATE/small-change.md
-    - source: .github/PULL_REQUEST_TEMPLATE/standard-change.md
     - source: .github/dependabot.yaml
     - source: .github/stale.yml
     - source: .github/workflows/cancel-previous-workflows.yaml

.github/workflows/clang-tidy-differential.yaml

@@ -20,14 +20,10 @@ jobs:
     runs-on: ubuntu-latest
     container: ghcr.io/autowarefoundation/autoware:latest-prebuilt-cuda
     steps:
-      - name: Set PR fetch depth
-        run: echo "PR_FETCH_DEPTH=$(( ${{ github.event.pull_request.commits }} + 1 ))" >> "${GITHUB_ENV}"
-
       - name: Checkout PR branch and all PR commits
         uses: actions/checkout@v4
         with:
-          ref: ${{ github.event.pull_request.head.sha }}
-          fetch-depth: ${{ env.PR_FETCH_DEPTH }}
+          fetch-depth: 0
 
       - name: Show disk space before the tasks
         run: df -h
@@ -41,19 +37,17 @@ jobs:
 
       - name: Get modified files
         id: get-modified-files
-        uses: tj-actions/changed-files@v42
-        with:
-          files: |
-            **/*.cpp
-            **/*.hpp
+        run: |
+          echo "changed_files=$(git diff --name-only "origin/${{ github.base_ref }}"...HEAD | grep -E '\.(cpp|hpp)$' | tr '\n' ' ' || true)" >> $GITHUB_OUTPUT
+        shell: bash
 
       - name: Run clang-tidy
-        if: ${{ steps.get-modified-files.outputs.all_changed_files != '' }}
+        if: ${{ steps.get-modified-files.outputs.changed_files != '' }}
         uses: autowarefoundation/autoware-github-actions/clang-tidy@v1
         with:
           rosdistro: humble
           target-packages: ${{ steps.get-modified-packages.outputs.modified-packages }}
-          target-files: ${{ steps.get-modified-files.outputs.all_changed_files }}
+          target-files: ${{ steps.get-modified-files.outputs.changed_files }}
           clang-tidy-config-url: https://raw.githubusercontent.com/autowarefoundation/autoware/main/.clang-tidy
           build-depends-repos: build_depends.repos
 

.github/workflows/comment-on-pr.yaml

@@ -0,0 +1,25 @@
+name: comment-on-pr
+on:
+  pull_request_target:
+
+jobs:
+  comment-on-pr:
+    runs-on: ubuntu-latest
+    permissions:
+      pull-requests: write
+    steps:
+      - name: Check out repository
+        uses: actions/checkout@v4
+
+      - name: Initial PR comment
+        uses: marocchino/sticky-pull-request-comment@v2
+        with:
+          message: |
+            Thank you for contributing to the Autoware project!
+
+            🚧 If your pull request is in progress, [switch it to draft mode](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-stage-of-a-pull-request#converting-a-pull-request-to-a-draft).
+
+            Please ensure:
+            - You've checked our [contribution guidelines](https://autowarefoundation.github.io/autoware-documentation/main/contributing/).
+            - Your PR follows our [pull request guidelines](https://autowarefoundation.github.io/autoware-documentation/main/contributing/pull-request-guidelines/).
+            - All required CI checks pass before [marking the PR ready for review](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-stage-of-a-pull-request#marking-a-pull-request-as-ready-for-review).

.github/workflows/cppcheck-daily.yaml

@@ -13,29 +13,16 @@ jobs:
       - name: Checkout code
         uses: actions/checkout@v2
 
-      - name: Install dependencies
+      # cppcheck from apt does not yet support --check-level args, and thus install from snap
+      - name: Install Cppcheck from snap
         run: |
-          sudo apt-get update
-          sudo apt-get install -y build-essential cmake git libpcre3-dev
-
-      # cppcheck from apt does not yet support --check-level args, and thus install from source
-      - name: Install Cppcheck from source
-        run: |
-          mkdir /tmp/cppcheck
-          git clone https://github.com/danmar/cppcheck.git /tmp/cppcheck
-          cd /tmp/cppcheck
-          git checkout 2.14.1
-          mkdir build
-          cd build
-          cmake ..
-          make -j $(nproc)
-          sudo make install
+          sudo snap install cppcheck
 
       - name: Run Cppcheck on all files
         continue-on-error: true
         id: cppcheck
         run: |
-          cppcheck --enable=all --inconclusive --check-level=exhaustive --error-exitcode=1 --xml . 2> cppcheck-report.xml
+          cppcheck --enable=all --inconclusive --check-level=exhaustive --suppress=*:*/test/* --error-exitcode=1 --xml . 2> cppcheck-report.xml
         shell: bash
 
       - name: Count errors by error ID and severity