refactor(shift_decider): prefix package and namespace with autoware_ (#…

…7310) * RT1-6684 add autoware prefix and namespace Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * RT1-6684 Revert svg This reverts commit 4e0569e. Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> --------- Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> Co-authored-by: Takayuki Murooka <[email protected]>
autowarefoundation · Jun 11, 2024 · 687ead9 · 687ead9
1 parent 822519d
commit 687ead9
Show file tree

Hide file tree

Showing 11 changed files with 42 additions and 34 deletions.
diff --git a/control/autoware_shift_decider/CMakeLists.txt b/control/autoware_shift_decider/CMakeLists.txt
@@ -0,0 +1,20 @@
+cmake_minimum_required(VERSION 3.14)
+project(autoware_shift_decider)
+
+find_package(autoware_cmake REQUIRED)
+autoware_package()
+
+ament_auto_add_library(${PROJECT_NAME}_node SHARED
+  src/${PROJECT_NAME}.cpp
+)
+
+rclcpp_components_register_node(${PROJECT_NAME}_node
+  PLUGIN "autoware::shift_decider::ShiftDecider"
+  EXECUTABLE ${PROJECT_NAME}
+)
+
+ament_auto_package(
+  INSTALL_TO_SHARE
+  launch
+  config
+)
diff --git a/control/shift_decider/README.md → control/autoware_shift_decider/README.md b/control/shift_decider/README.md → control/autoware_shift_decider/README.md
@@ -2,7 +2,7 @@
 
 ## Purpose
 
-`shift_decider` is a module to decide shift from ackermann control command.
+`autoware_shift_decider` is a module to decide shift from ackermann control command.
 
 ## Inner-workings / Algorithms
 

diff --git a/...t_decider/config/shift_decider.param.yaml → ...t_decider/config/shift_decider.param.yaml b/...t_decider/config/shift_decider.param.yaml → ...t_decider/config/shift_decider.param.yaml
diff --git a/...r/include/shift_decider/shift_decider.hpp → ..._shift_decider/autoware_shift_decider.hpp b/...r/include/shift_decider/shift_decider.hpp → ..._shift_decider/autoware_shift_decider.hpp
@@ -12,8 +12,8 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#ifndef SHIFT_DECIDER__SHIFT_DECIDER_HPP_
-#define SHIFT_DECIDER__SHIFT_DECIDER_HPP_
+#ifndef AUTOWARE_SHIFT_DECIDER__AUTOWARE_SHIFT_DECIDER_HPP_
+#define AUTOWARE_SHIFT_DECIDER__AUTOWARE_SHIFT_DECIDER_HPP_
 
 #include <rclcpp/rclcpp.hpp>
 
@@ -24,6 +24,9 @@
 
 #include <memory>
 
+namespace autoware::shift_decider
+{
+
 class ShiftDecider : public rclcpp::Node
 {
 public:
@@ -52,5 +55,6 @@ class ShiftDecider : public rclcpp::Node
 
   bool park_on_goal_;
 };
+}  // namespace autoware::shift_decider
 
-#endif  // SHIFT_DECIDER__SHIFT_DECIDER_HPP_
+#endif  // AUTOWARE_SHIFT_DECIDER__AUTOWARE_SHIFT_DECIDER_HPP_
diff --git a/...t_decider/launch/shift_decider.launch.xml → ...t_decider/launch/shift_decider.launch.xml b/...t_decider/launch/shift_decider.launch.xml → ...t_decider/launch/shift_decider.launch.xml
@@ -1,7 +1,7 @@
 <launch>
-  <arg name="config_file" default="$(find-pkg-share shift_decider)/config/shift_decider.param.yaml"/>
+  <arg name="config_file" default="$(find-pkg-share autoware_shift_decider)/config/shift_decider.param.yaml"/>
 
-  <node pkg="shift_decider" exec="shift_decider" name="shift_decider" output="screen">
+  <node pkg="autoware_shift_decider" exec="autoware_shift_decider" name="autoware_shift_decider" output="screen">
     <remap from="input/control_cmd" to="/control/trajectory_follower/control_cmd"/>
     <remap from="input/state" to="/autoware/state"/>
     <remap from="output/gear_cmd" to="/control/shift_decider/gear_cmd"/>

diff --git a/control/shift_decider/package.xml → control/autoware_shift_decider/package.xml b/control/shift_decider/package.xml → control/autoware_shift_decider/package.xml
@@ -1,9 +1,9 @@
 <?xml version="1.0"?>
 <?xml-model href="http://download.ros.org/schema/package_format3.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
 <package format="3">
-  <name>shift_decider</name>
+  <name>autoware_shift_decider</name>
   <version>0.1.0</version>
-  <description>The shift_decider package</description>
+  <description>The autoware_shift_decider package</description>
   <maintainer email="[email protected]">Takamasa Horibe</maintainer>
   <maintainer email="[email protected]">Takayuki Murooka</maintainer>
   <license>Apache License 2.0</license>

diff --git a/..._decider/schema/shift_decider.schema.json → ..._decider/schema/shift_decider.schema.json b/..._decider/schema/shift_decider.schema.json → ..._decider/schema/shift_decider.schema.json
diff --git a/control/shift_decider/src/shift_decider.cpp → ...ft_decider/src/autoware_shift_decider.cpp b/control/shift_decider/src/shift_decider.cpp → ...ft_decider/src/autoware_shift_decider.cpp
@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#include "shift_decider/shift_decider.hpp"
+#include "autoware_shift_decider/autoware_shift_decider.hpp"
 
 #include <rclcpp/timer.hpp>
 
@@ -21,6 +21,9 @@
 #include <memory>
 #include <utility>
 
+namespace autoware::shift_decider
+{
+
 ShiftDecider::ShiftDecider(const rclcpp::NodeOptions & node_options)
 : Node("shift_decider", node_options)
 {
@@ -104,6 +107,7 @@ void ShiftDecider::initTimer(double period_s)
   timer_ =
     rclcpp::create_timer(this, get_clock(), period_ns, std::bind(&ShiftDecider::onTimer, this));
 }
+}  // namespace autoware::shift_decider
 
 #include <rclcpp_components/register_node_macro.hpp>
-RCLCPP_COMPONENTS_REGISTER_NODE(ShiftDecider)
+RCLCPP_COMPONENTS_REGISTER_NODE(autoware::shift_decider::ShiftDecider)
diff --git a/control/shift_decider/CMakeLists.txt b/control/shift_decider/CMakeLists.txt
diff --git a/launch/tier4_control_launch/launch/control.launch.py b/launch/tier4_control_launch/launch/control.launch.py
@@ -122,9 +122,9 @@ def launch_setup(context, *args, **kwargs):
 
     # shift decider
     shift_decider_component = ComposableNode(
-        package="shift_decider",
-        plugin="ShiftDecider",
-        name="shift_decider",
+        package="autoware_shift_decider",
+        plugin="autoware::shift_decider::ShiftDecider",
+        name="autoware_shift_decider",
         remappings=[
             ("input/control_cmd", "/control/trajectory_follower/control_cmd"),
             ("input/state", "/autoware/state"),

diff --git a/launch/tier4_control_launch/package.xml b/launch/tier4_control_launch/package.xml
@@ -14,9 +14,9 @@
   <exec_depend>autoware_external_cmd_converter</exec_depend>
   <exec_depend>autoware_external_cmd_selector</exec_depend>
   <exec_depend>autoware_lane_departure_checker</exec_depend>
+  <exec_depend>autoware_shift_decider</exec_depend>
   <exec_depend>autoware_vehicle_cmd_gate</exec_depend>
   <exec_depend>control_evaluator</exec_depend>
-  <exec_depend>shift_decider</exec_depend>
   <exec_depend>trajectory_follower_node</exec_depend>
 
   <test_depend>ament_lint_auto</test_depend>