-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(source-installation): recommend installation via Ansible over manual installation #369
feat(source-installation): recommend installation via Ansible over manual installation #369
Conversation
Signed-off-by: Yukihito Saito <[email protected]>
Signed-off-by: Yukihito Saito <[email protected]>
Signed-off-by: Yukihito Saito <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Yukihito Saito <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If not using ansible is causing installation issue, then I don't mind making them a default installation step.
However, I believe one of the issue with ansible was that it might corrupt the users environment if they already have NVIDIA related libraries. I made some suggestions to make it obvious that users with NVIDIA libraries installed should be careful using the ansible script.
Co-authored-by: Ryohsuke Mitsudome <[email protected]>
Co-authored-by: Ryohsuke Mitsudome <[email protected]>
Signed-off-by: Yukihito Saito <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd still prefer to keep manual installation steps under a separate heading instead of a Note section.
But I leave the decision to you @yukkysaito . But I am sure some people will complain that Ansible method has made unwanted changes on their system, time will tell.
I've made some rephrasing of some sentences along the way. After you review them, I think we can merge this.
Co-authored-by: M. Fatih Cırıt <[email protected]>
Co-authored-by: M. Fatih Cırıt <[email protected]>
Co-authored-by: M. Fatih Cırıt <[email protected]>
Co-authored-by: M. Fatih Cırıt <[email protected]>
@xmfcx
Do you mean to create a manual installation page in troubleshooting or somewhere else?
In japan, many people say installing Autoware is too difficult. also, installing Autoware is called "Autoware challenge".
Thank you very much. I committed the fix. |
@kenji-miyake @xmfcx @yukkysaito Sorry, didn't see this before. I still prefer the manual installation and I think it's not good for users to have their environment changed via a script without their control (see for example installing rocker via However the work done in autowarefoundation/autoware#3222 should largely make some of the Ansible steps obsolete, since users will be able to install Autoware directly from Debian packages (see https://github.com/esteve/autoware_packages/tree/jammy-humble for an APT repository that users can already use to install Autoware). In any case, as long as the manual instructions are kept and that the Ansible scripts do not modify a user's environment without their consent, I'm fine. |
…nual installation (autowarefoundation#369) Signed-off-by: Yukihito Saito <[email protected]> Co-authored-by: Ryohsuke Mitsudome <[email protected]> Co-authored-by: M. Fatih Cırıt <[email protected]> Signed-off-by: guiping meng <[email protected]>
Description
I see many people on social media doing manual installations instead of automated environment setups using Ansible.
Manual installation is difficult and many people fail.
Therefore, I have changed to recommend automatic environment setup using Ansible.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The Reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.