Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: using uv to setup python and install dependencies for github actions #152

Merged
merged 42 commits into from
Nov 25, 2024

Conversation

timurcarstensen
Copy link
Member

@timurcarstensen timurcarstensen commented Oct 25, 2024

changes

  • uses uv for venv and installing dependencies in our github actions workflows
  • switches to PEP 621 for pyproject.toml and discards of poetry

todo

  • update docs
  • update other workflows
  • Add a uv build line to the contributing docs for the publishing part

@timurcarstensen timurcarstensen marked this pull request as draft October 25, 2024 14:56
Copy link
Contributor

@eddiebergman eddiebergman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good at a glance although you've have to update the documentation/contributing guide as well. I recommend searching up for the string "poetry" to find sources of it.

@timurcarstensen timurcarstensen marked this pull request as ready for review November 25, 2024 09:32
Copy link
Contributor

@eddiebergman eddiebergman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally big fan, just want to check that pyproject.toml gets updated to remove peotry?

Also would mean poetry publish would cease to work

CONTRIBUTING.md Outdated Show resolved Hide resolved
@timurcarstensen timurcarstensen merged commit 5e40590 into master Nov 25, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants