allow empty string for client_secret in TokenClient #1738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamapa
reviewed
Dec 9, 2024
| @@ -112,7 +112,7 @@ export class TokenClient { | |||
| let basicAuth: string | undefined; | |||
| switch (this._settings.client_authentication) { | |||
| case "client_secret_basic": | |||
| if (!client_secret) { | |||
| if (client_secret === undefined || client_secret === null) { | |||
There was a problem hiding this comment.
!client_secret is the same as client_secret === undefined || client_secret === null, both evaluate to true when client_secret is null or undefined
There was a problem hiding this comment.
@pamapa
Thanks for the feedback. You’re correct that !client_secret and client_secret === undefined || client_secret === null behave similarly when checking for null or undefined. However, the reason for the change is that I want to allow an empty string as a valid value.
Using !client_secret would exclude an empty string because it’s considered “falsy,” but by explicitly checking for undefined and null, I can ensure that empty strings are still permitted.
This is intentional, so I appreciate you pointing it out.
pamapa
changed the title
pamapa
changed the title
pamapa
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes/fixes #1068 and #1438
Checklist
This pull request includes changes to the TokenClient class in the src/TokenClient.ts file to improve the handling of the client_secret parameter. The changes ensure that the client_secret is explicitly checked for undefined or null values, rather than using a falsy check. This modification allows empty strings as valid client_secret values when using client_secret_basic authentication method, which was previously rejected by the falsy check.