Merge pull request #1738 from ntamotsu/patch-1

allow empty string for client_secret in TokenClient
authts · Dec 18, 2024 · 743783e · 743783e
2 parents ef3a385 + 7cd651a
commit 743783e
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/TokenClient.ts b/src/TokenClient.ts
@@ -112,7 +112,7 @@ export class TokenClient {
         let basicAuth: string | undefined;
         switch (this._settings.client_authentication) {
             case "client_secret_basic":
-                if (!client_secret) {
+                if (client_secret === undefined || client_secret === null) {
                     logger.throw(new Error("A client_secret is required"));
                     throw null; // https://github.com/microsoft/TypeScript/issues/46972
                 }
@@ -173,7 +173,7 @@ export class TokenClient {
         let basicAuth: string | undefined;
         switch (this._settings.client_authentication) {
             case "client_secret_basic":
-                if (!client_secret) {
+                if (client_secret === undefined || client_secret === null) {
                     logger.throw(new Error("A client_secret is required"));
                     throw null; // https://github.com/microsoft/TypeScript/issues/46972
                 }
@@ -229,7 +229,7 @@ export class TokenClient {
         let basicAuth: string | undefined;
         switch (this._settings.client_authentication) {
             case "client_secret_basic":
-                if (!client_secret) {
+                if (client_secret === undefined || client_secret === null) {
                     logger.throw(new Error("A client_secret is required"));
                     throw null; // https://github.com/microsoft/TypeScript/issues/46972
                 }