Adding shouldFieldBePreserved function
#736
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 83.60% // Head: 83.65% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #736 +/- ##
==========================================
+ Coverage 83.60% 83.65% +0.04%
==========================================
Files 114 115 +1
Lines 3379 3389 +10
Branches 628 629 +1
==========================================
+ Hits 2825 2835 +10
Misses 324 324
Partials 230 230
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Closed because wrong Jira ticket number associated with branch name. Reopened with #738. |
This was referenced Feb 13, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
The first part of many to implement a fix for #328. At the most basic level, we need to identify which fields to preserve before can actually preserve them.
This function doesn't serve much function in its current form, but it will be used by higher-order functions to compose the keyword preservation functionality.
This PR starts to lay the foundation for the keyword preservation code in both the
keywordPreservation.tsfile as well as the accompanying test file.📚 References
Related Issues:
🔬 Testing
Many unit tests included to cover a wide-range of situations.
📝 Checklist