DXCDT-376: Preserve keywords function #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willvedd
changed the base branch from
master
to
DXCDT-374-keyword-preservation-update-field-by-address
… into DXCDT-376-preserve-keywords-function
willvedd
commented
Feb 21, 2023
Comment on lines
24
to
+27
| export const getPreservableFieldsFromAssets = ( | ||
| asset: any, | ||
| address: string, | ||
| keywordMappings: KeywordMappings | ||
| asset: object, | ||
| keywordMappings: KeywordMappings, | ||
| address = '' |
There was a problem hiding this comment.
Re-ordering the arguments, particularly making keywordMappings second to be more consistent with the other functions of that file.
Codecov ReportBase: 83.86% // Head: 83.93% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## DXCDT-374-keyword-preservation-update-field-by-address #745 +/- ##
==========================================================================================
+ Coverage 83.86% 83.93% +0.07%
==========================================================================================
Files 115 115
Lines 3445 3462 +17
Branches 647 650 +3
==========================================================================================
+ Hits 2889 2906 +17
Misses 324 324
Partials 232 232
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
sergiught
approved these changes
Feb 21, 2023
Base automatically changed from
DXCDT-374-keyword-preservation-update-field-by-address
to
master
February 21, 2023 22:24
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
Building off of the previous PRs for keyword preservation (#736, #738, #740, #741, #744), this PR introduces the
preserveKeywordsfunction. This is the highest-order function of this feature and the one that will ultimately be integrated into the export process. As the name suggests, it preserves keywords when provided local assets, remote assets and keyword mappings. The result is an altered copy of the remote assets with the keywords appropriately replaced.📚 References
Related Issues:
🔬 Testing
Added relevant unit tests.
📝 Checklist