Fix: Client grants test #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
In #684 we removed the tenant-specific audience name from dumped client grant filenames. However, we did not also adequately adjust the tests. Problematically, these tests were failing in the Circle CI PR checks but for some reason didn't return a non-zero exit code. Definitely a huge problem but something to fix in a following PR.
This PR fixes our tests to ensure that our testing suite passes.
📚 References
Source of breaking tests: #684, see also failing tests in CI.
🔬 Testing
Tests pass.
📝 Checklist