Fix: CircleCI check should fail if unit tests fail #709
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
Currently, our unit test suite is failing but gets marked as a pass in CircleCi. The
npm run test:coverage
is a composition of two commands, running unit tests and generating test coverage. These two commands are joined by a semicolon (;
) which means that the exit code of the first command is essentially ignored in favor of the test coverage command, which rarely exits with a non-zero code. Instead, these commands should be joined with&&
to signal an error if either two of the commands returns a non-zero exit code. Example of tests failing in CI but passing the stage.📚 References
Example
🔬 Testing
Running
npm run test:coverage
followed byecho $?
to verify the exit code of the resulting change.📝 Checklist