New test to create l2vpns and check connectivity #8

gretelliz · 2024-11-25T14:51:10Z

Create a new tests on the L2VPN creation:

test_060_create_and_delete_l2vpn: Create 10 l2vpn between differnet endpoints of the topology, randomly remove 5 of them, and test the connectivity between then.

italovalcy

Hi Gretel! Excellent pull request, very nice to see how this is progressing! One thing, though that I would like to require your help is: I see the testing is leveraging ping among switches to check connectivity, but I want to ask you to test connectivity using ping among hosts. Testing connectivity using switches will give you a false positive output because switches all run as process in the emulation host, so it will work as a ping to localhost

gretelliz · 2024-11-29T23:38:45Z

Thank you very much @italovalcy. Please, note that I have made changes based on your comments.

…_codes.py Rename file

italovalcy

Hi Gretel, congratulations on the pull request adding this new test! Amazing to see how this is progressing! I made a few comments to contribute on the testing methodology, suggesting the removal of some sleeps and also changes on the execution order and formatting style. Please let me know what you think!

italovalcy · 2024-12-11T18:19:02Z

tests/test_05_l2vpn.py

+        payload = {"name": "Text", "endpoints":
+                   [{"port_id": "urn:sdx:port:ampath.net:Ampath1:50", "vlan": "100",},
+                    {"port_id": "urn:sdx:port:tenet.ac.za:Tenet03:50", "vlan": "100",},],}


@gretelliz can you please fix the formatting rules here? for example:

payload = { "name": "Text", "endpoints": [ {"port_id": "urn:sdx:port:ampath.net:Ampath1:50", "vlan": "100"}, {"port_id": "urn:sdx:port:tenet.ac.za:Tenet03:50", "vlan": "100"} ] }

italovalcy · 2024-12-11T22:35:21Z

tests/test_05_l2vpn.py

+        payload = {"name": "Text", "endpoints":
+                   [{"port_id": "urn:sdx:port:ampath.net:Ampath1:50", "vlan": "101",},
+                    {"port_id": "urn:sdx:port:tenet.ac.za:Tenet03:50", "vlan": "101",},],}


italovalcy · 2024-12-11T22:35:37Z

tests/test_05_l2vpn.py

+        payload = {"name": "Text", "endpoints":
+                   [{"port_id": "urn:sdx:port:ampath.net:Ampath1:50", "vlan": "102",},
+                    {"port_id": "urn:sdx:port:tenet.ac.za:Tenet03:50", "vlan": "102",},],}


italovalcy · 2024-12-11T22:36:48Z

tests/test_05_l2vpn.py

+        # wait a few seconds for convergency
+        time.sleep(30)


not sure if I understood the convergency here. From the previous commands, there was no links going down

You're right, the comment is confusing. This is some time after removing a link.

italovalcy · 2024-12-11T22:37:25Z

tests/test_05_l2vpn.py

+        h8.cmd('ip addr add 10.1.1.8/24 dev vlan102')
+
+        result = h1.cmd('ping -c4 10.1.1.8')
+        assert ', 0% packet loss,' in result


I recommend that the assert goes in the end, to allow the VLAN interfaces be removed before actually checking for the results (and possibly failing, leaving the clean up incomplete).

italovalcy · 2024-12-11T22:37:35Z

tests/test_05_l2vpn.py

+        assert ', 0% packet loss,' in result
+
+        # link down
+        h1.cmd('ip link del vlan102')


leave this to the end

italovalcy · 2024-12-12T07:24:34Z

tests/test_05_l2vpn.py

+        h1.cmd('ip link del vlan101')
+
+        # wait a few seconds for convergency
+        time.sleep(30)


not necessary

italovalcy · 2024-12-12T07:24:46Z

tests/test_05_l2vpn.py

+        h1.cmd('ip link del vlan100')
+
+        # wait a few seconds -> there are no links left
+        time.sleep(30)


not necessary

gretelliz · 2024-12-12T22:12:10Z

@italovalcy, thank you very much for your review and comments. Note that I have made a new push.

italovalcy · 2024-12-17T18:16:43Z

@italovalcy, thank you very much for your review and comments. Note that I have made a new push.

Hi Gretel, I'm still seeing some of the comments I made last review as pending. Are you still working on those adjustments?

E2e tests

gretelliz · 2024-12-17T18:50:41Z

Hello @italovalcy. I don't have anything pending regarding this PR, I think I have covered all your recommendations.

italovalcy · 2024-12-18T17:45:03Z

tests/test_05_l2vpn.py

+        assert response.status_code == 201, response.text
+        h1.cmd('ip link add link %s name vlan101 type vlan id 101' % (h1.intfNames()[0]))
+        h1.cmd('ip link set up vlan101')
+        h1.cmd('ip addr add 10.1.1.1/24 dev vlan101')


Gretel, can you please update the IP address assigned to VLAN 101 to something different? Example: 10.1.2.1/24

italovalcy · 2024-12-18T17:45:17Z

tests/test_05_l2vpn.py

+        h1.cmd('ip addr add 10.1.1.1/24 dev vlan101')
+        h8.cmd('ip link add link %s name vlan100 type vlan id 101' % (h8.intfNames()[0]))
+        h8.cmd('ip link set up vlan101')
+        h8.cmd('ip addr add 10.1.1.8/24 dev vlan101')


italovalcy · 2024-12-18T17:45:39Z

tests/test_05_l2vpn.py

+        assert response.status_code == 201, response.text
+        h1.cmd('ip link add link %s name vlan102 type vlan id 102' % (h1.intfNames()[0]))
+        h1.cmd('ip link set up vlan102')
+        h1.cmd('ip addr add 10.1.1.1/24 dev vlan102')


same here regarding the IP address

italovalcy · 2024-12-18T17:45:46Z

tests/test_05_l2vpn.py

+        h1.cmd('ip addr add 10.1.1.1/24 dev vlan102')
+        h8.cmd('ip link add link %s name vlan102 type vlan id 102' % (h8.intfNames()[0]))
+        h8.cmd('ip link set up vlan102')
+        h8.cmd('ip addr add 10.1.1.8/24 dev vlan102')


same here regarding the IP address

italovalcy · 2024-12-18T17:51:47Z

tests/test_05_l2vpn.py

+
+        # test connectivity again
+        result = h1.cmd('ping -c4 10.1.1.8')
+        assert ', 0% packet loss,' in result


After testing all the connectivity, I suggest you to remove all the interfaces from h1 and h8:

h1.cmd('ip link del vlan100') h1.cmd('ip link del vlan101') h1.cmd('ip link del vlan102') h8.cmd('ip link del vlan100') h8.cmd('ip link del vlan101') h8.cmd('ip link del vlan102')

italovalcy · 2024-12-18T17:52:42Z

tests/test_05_l2vpn.py

+        time.sleep(30)
+
+        # test connectivity again
+        result = h1.cmd('ping -c4 10.1.1.8')


I suggest you to have different variables to store the ping result from each VLAN:

result_100 = h1.cmd('ping -c4 10.1.1.8') result_101 = h1.cmd('ping -c4 10.1.2.8') result_102 = h1.cmd('ping -c4 10.1.3.8')

…-sdx/sdx-end-to-end-tests into e2e_tests_topology

gretelliz · 2024-12-20T22:39:18Z

@italovalcy, note that the last two asserts in this last commit are commented out, they fail. Should that be the behavior?

New test to create l2vpns and check connectivity

d5e5f85

gretelliz requested a review from italovalcy November 25, 2024 14:51

New test to create l2vpns and check connectivity (change)

dff4489

italovalcy reviewed Nov 27, 2024

View reviewed changes

Test to create l2vpns, set link to down and check connectivity

fc9d54d

gretelliz requested a review from italovalcy December 2, 2024 16:14

gretelliz and others added 5 commits December 3, 2024 22:21

Test return codes

4aaf29c

new codes to test return codes for creating l2vpn

41ab816

Rename test_06_creating_l2vpn_return_codes.py to test_06_l2vpn_return…

156f18a

…_codes.py Rename file

new codes to test return codes for creating l2vpn (2)

1db8e18

new test for return codes for creating l2vpn

59cd4a5

italovalcy requested changes Dec 12, 2024

View reviewed changes

italovalcy mentioned this pull request Dec 12, 2024

E2e tests #9

Merged

change in test_060_link_convergency_with_l2vpn_with_alternative_paths

ecb3982

gretelliz requested a review from italovalcy December 12, 2024 22:12

gretelliz and others added 2 commits December 13, 2024 14:50

format changes

db7ee21

Merge branch 'e2e_tests_topology' into e2e_tests

382b6e4

Merge pull request #9 from atlanticwave-sdx/e2e_tests

2c7be24

E2e tests

italovalcy reviewed Dec 18, 2024

View reviewed changes

gretelliz added 2 commits December 20, 2024 17:34

nre version for link_convergency_with_l2vpn_with_alternative_paths

c874d09

Merge branch 'e2e_tests_topology' of https://github.com/atlanticwave…

ae4286b

…-sdx/sdx-end-to-end-tests into e2e_tests_topology

gretelliz requested a review from italovalcy December 20, 2024 22:39

lmarinve assigned gretelliz Jan 8, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New test to create l2vpns and check connectivity #8

New test to create l2vpns and check connectivity #8

gretelliz commented Nov 25, 2024

italovalcy left a comment

gretelliz commented Nov 29, 2024

italovalcy left a comment

italovalcy Dec 11, 2024

italovalcy Dec 11, 2024

italovalcy Dec 11, 2024

italovalcy Dec 11, 2024

gretelliz Dec 12, 2024

italovalcy Dec 11, 2024

italovalcy Dec 11, 2024

italovalcy Dec 12, 2024

italovalcy Dec 12, 2024

gretelliz commented Dec 12, 2024

italovalcy commented Dec 17, 2024

gretelliz commented Dec 17, 2024

italovalcy Dec 18, 2024

italovalcy Dec 18, 2024

italovalcy Dec 18, 2024

italovalcy Dec 18, 2024

italovalcy Dec 18, 2024

italovalcy Dec 18, 2024

gretelliz commented Dec 20, 2024

New test to create l2vpns and check connectivity #8

Are you sure you want to change the base?

New test to create l2vpns and check connectivity #8

Conversation

gretelliz commented Nov 25, 2024

italovalcy left a comment

Choose a reason for hiding this comment

gretelliz commented Nov 29, 2024

italovalcy left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gretelliz commented Dec 12, 2024

italovalcy commented Dec 17, 2024

gretelliz commented Dec 17, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gretelliz commented Dec 20, 2024