E2e tests #9
Merged
E2e tests #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
italovalcy
reviewed
Dec 4, 2024
There was a problem hiding this comment.
Hi @gretelliz as we discussed on today's meeting, can you please refactor this test and split the return code validation function into a new file, let's say test_06_l2vpn_return_codes.py ?
|
Sure @italovalcy, please note that I did what you suggested in the last commit. |
italovalcy
requested changes
Dec 12, 2024
There was a problem hiding this comment.
Hi Gretel, amazing to see how this is progressing well! Congratulations! I have two comments for you please to consider:
- Can you please make a slight change on the name of the tests to add a very short description about what the test is doing? I added suggestions for the two first ones, but please also apply this change on the others!
- Can you please run a pylint or similar on this code? I see a few commas on the wrong place and pylint will help you identify some improvements on the formatting style.
italovalcy
reviewed
Dec 12, 2024
|
Thank you for your review @italovalcy. |
italovalcy
approved these changes
Dec 17, 2024
|
@italovalcy, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to test the return codes.