Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass loop attribute to asyncio.ensure_future #66

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Pass loop attribute to asyncio.ensure_future #66

wants to merge 1 commit into from

Conversation

max-k
Copy link

@max-k max-k commented Nov 3, 2020

If we specify a custom event loop at worker instantiation, it has to also be used by asyncio instead of default one.

Description

In some situation (for example in integration tests of Faust agents), I have to retry worker startup because kafka is not yet available.

But the first time I run execute_from_commandline, the default event loop is closed so I have to create a new one before calling execute_from_commandline again.

Unfortunately, custom event loop is not properly transmitted to asyncio, so it automatically makes use of default event loop and raise a RuntimeError('Event loop is closed').

With this simple fix, user-specified event loop will be properly transmitted to asyncio.

If we specify a custom event loop at worker instantiation, it has to also be used by asyncio instead of default one.
@pawelswiecki
Copy link

Any updates on this MR?

I'm most likely facing the exact same problem. Any ideas for a temporary workaround?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants