Pass loop attribute to asyncio.ensure_future #66
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we specify a custom event loop at worker instantiation, it has to also be used by asyncio instead of default one.
Description
In some situation (for example in integration tests of Faust agents), I have to retry worker startup because kafka is not yet available.
But the first time I run
execute_from_commandline
, the default event loop is closed so I have to create a new one before callingexecute_from_commandline
again.Unfortunately, custom event loop is not properly transmitted to asyncio, so it automatically makes use of default event loop and raise a
RuntimeError('Event loop is closed')
.With this simple fix, user-specified event loop will be properly transmitted to asyncio.