Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do you plan to also fork mode, because it seems abandonned. #43

Closed
max-k opened this issue Nov 20, 2020 · 9 comments
Closed

Do you plan to also fork mode, because it seems abandonned. #43

max-k opened this issue Nov 20, 2020 · 9 comments

Comments

@max-k
Copy link
Contributor

max-k commented Nov 20, 2020

Hi,

Thank you for your work.

Do you plan to also fork mode ?

It is another project formerly maintained by a robinhood employee and today it looks abandoned.

It is an important dependency of Faust so it could be valuable to keep it updated in parallel of your Faust fork.

If there is anything I can do help you in this process, just ask.

Thank you very much.

@patkivikram
Copy link
Collaborator

patkivikram commented Nov 20, 2020

Are there any pending feature/bugs that need to be addressed?

@max-k
Copy link
Contributor Author

max-k commented Nov 23, 2020

Hi,

Yes, at least the PR I made on the project to fix a bug regarding custom event loop usage.

Pass loop attribute to asyncio.ensure_future #66

@patkivikram
Copy link
Collaborator

We can make a fork of it. Should I add you as a maintainer @max-k ? That way you can create a fork of it and merge it

@max-k
Copy link
Contributor Author

max-k commented Nov 25, 2020

I'm not sure to have enough skills to maintain the whole thing but I can try to help, at least.

@max-k
Copy link
Contributor Author

max-k commented Dec 1, 2020

Hi,
I made the fork and re-create my MR on it.
I'm currently updating the README.
Do you have a suggestion for the name of the python artifact ? (mode-fork ? mode-streaming ? faust-streaming-mode ?)

@patkivikram
Copy link
Collaborator

mode-streaming? I will leave it to you :)

@max-k
Copy link
Contributor Author

max-k commented Dec 7, 2020

mode-streaming sounds not so bad. Let's go for it. Thank you very much.

@max-k max-k closed this as completed Dec 7, 2020
@lqhuang
Copy link

lqhuang commented Feb 4, 2021

@max-k Hey, thanks for your effort. I have created a pull request from two weeks ago faust-streaming/mode#6, but it's still in pending state. Could you take a look? Do you still pay time to keep maintaining mode? I volunteer to be a maintainer of this fork. A lot of my applications are depending on mode package. So, I have to and hope to keep bug fix even add more features to mode. Of course, the compatibility to faust-streaming is the first priority. @patkivikram

@max-k
Copy link
Contributor Author

max-k commented Feb 7, 2021

Hi @lqhuang , Thank you for your contribution. I'll take a look at it as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants