fix(controller): step group stuck on running when exit hook has illegal expression

[chengjoey]

Fixes #14031

Motivation

The error handling logic for stepGroup on exithook with illegal expressions should be consistent with Dag.

argo-workflows/workflow/controller/dag.go

Lines 289 to 300 in 27a5938

	if taskNode.Fulfilled() {
	if taskNode.Completed() {
	hasOnExitNode, onExitNode, err := woc.runOnExitNode(ctx, dagCtx.GetTask(taskName).GetExitHook(woc.execWf.Spec.Arguments), taskNode, dagCtx.boundaryID, dagCtx.tmplCtx, "tasks."+taskName, scope)
	if err != nil {
	return node, err
	}
	if hasOnExitNode && (onExitNode == nil || !onExitNode.Fulfilled()) {
	onExitCompleted = false
	}
	}
	}
	}

Modifications

[jswxstw]

It would be best to update the explanation in the comments as well.

[chengjoey]

done

[jswxstw]

I ran the example from #14031 and found that node StepGroup[1] still remains Running. This issue seems to be quite common when workflow is marked as Error directly.

[jswxstw]

argo-workflows/workflow/controller/steps.go

Lines 110 to 113 in 27a5938

	sgNode, err := woc.executeStepGroup(ctx, stepGroup.Steps, sgNodeName, &stepsCtx)
	if err != nil {
	return nil, err
	}

I think there is also need to mark sgNode as Error as I commented before: #14032 (comment).

if err != nil {
    return woc.markNodeError(sgNodeName, err), nil
}

[chengjoey]

I think there is also need to mark sgNode as Error as I commented before: #14032 (comment).

thanks @jswxstw , done