fix(controller): step group stuck on running when exit hook has inval…

…id expression

Signed-off-by: joey <[email protected]>

util/expr/argoexpr/eval_test.go

@@ -58,6 +58,17 @@ func TestEvalBool(t *testing.T) {
 			want:    true,
 			wantErr: false,
 		},
+		{
+			name: "test null expression",
+			args: args{
+				input: "steps[\"prepare\"].outputs != null",
+				env: map[string]interface{}{"steps": map[string]interface{}{
+					"prepare": map[string]interface{}{"outputs": "msg"},
+				}},
+			},
+			want:    false,
+			wantErr: true,
+		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {

workflow/controller/steps.go

@@ -330,8 +330,10 @@ func (woc *wfOperationCtx) executeStepGroup(ctx context.Context, stepGroup []wfv
 			completed = false
 		} else if childNode.Completed() {
 			hasOnExitNode, onExitNode, err := woc.runOnExitNode(ctx, step.GetExitHook(woc.execWf.Spec.Arguments), childNode, stepsCtx.boundaryID, stepsCtx.tmplCtx, "steps."+step.Name, stepsCtx.scope)
-			if hasOnExitNode && (onExitNode == nil || !onExitNode.Fulfilled() || err != nil) {
-				// The onExit node is either not complete or has errored out, return.
+			if err != nil {
+				return node, err
+			}
+			if hasOnExitNode && (onExitNode == nil || !onExitNode.Fulfilled()) {
 				completed = false
 			}
 		}