Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove node poly #7

Closed
wants to merge 6 commits into from
Closed

test: remove node poly #7

wants to merge 6 commits into from

Conversation

fedellen
Copy link
Collaborator

doesn't quite succeed yarn && yarn build

            ^
5: export async function deepHash(data) {
6:     if (typeof data[Symbol.asyncIterator] === "function") {
error during build:
RollupError: "createHash" is not exported by "__vite-browser-external", imported by "node_modules/arbundles/build/web/esm/src/deepHash.js".
    at error (file:///Users/derek/ar-io/turbo-app/node_modules/rollup/dist/es/shared/parseAst.js:337:30)
    at Module.error (file:///Users/derek/ar-io/turbo-app/node_modules/rollup/dist/es/shared/node-entry.js:12738:16)
    at Module.traceVariable (file:///Users/derek/ar-io/turbo-app/node_modules/rollup/dist/es/shared/node-entry.js:13175:29)
    at ModuleScope.findVariable (file:///Users/derek/ar-io/turbo-app/node_modules/rollup/dist/es/shared/node-entry.js:11592:39)
    at FunctionScope.findVariable (file:///Users/derek/ar-io/turbo-app/node_modules/rollup/dist/es/shared/node-entry.js:5897:38)
    at FunctionBodyScope.findVariable (file:///Users/derek/ar-io/turbo-app/node_modules/rollup/dist/es/shared/node-entry.js:5897:38)
    at TrackingScope.findVariable (file:///Users/derek/ar-io/turbo-app/node_modules/rollup/dist/es/shared/node-entry.js:5897:38)
    at BlockScope.findVariable (file:///Users/derek/ar-io/turbo-app/node_modules/rollup/dist/es/shared/node-entry.js:5897:38)
    at Identifier.bind (file:///Users/derek/ar-io/turbo-app/node_modules/rollup/dist/es/shared/node-entry.js:7179:40)
    at CallExpression.bind (file:///Users/derek/ar-io/turbo-app/node_modules/rollup/dist/es/shared/node-entry.js:4625:23)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

@dtfiedler
Copy link

we can look to add the polyfill in the SDK web build to fix

dtfiedler added 2 commits December 13, 2023 18:27
The updates the the SDK allow us to remove the vite polyfills.
@dtfiedler
Copy link

dtfiedler commented Dec 14, 2023

@fedellen - pushed a new alpha version here and pulled it in. looks to resolve our polyfill issues. also added named imports.

@fedellen fedellen changed the base branch from PE-5161_cancel_query_params to prod December 14, 2023 17:27
@fedellen
Copy link
Collaborator Author

fedellen commented Dec 14, 2023

runs on my end and LGTM. this is my PR so i can't approve. feel free to approve and merge

@fedellen fedellen marked this pull request as draft April 19, 2024 20:50
@dtfiedler dtfiedler closed this Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants