feat: create the gift app PE-5161 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedellen
changed the title
fedellen
changed the title
fedellen
force-pushed
the
PE-5161_gift_app_init
branch
from
d340947 to
ddb12e5
Compare
fedellen
force-pushed
the
PE-5161_gift_app_init
branch
from
72e299c to
f54b86d
Compare
fedellen
commented
Dec 7, 2023
fedellen
commented
Dec 7, 2023
| - name: Build | ||
| run: yarn build | ||
|
|
||
| - name: Deploy gh-pages if on prod |
There was a problem hiding this comment.
fwiw I learned we can add dev dependency gh-pages and add a deploy command like yarn gh-pages (but this is working and fine)
fedellen
requested review from
kunstmusik,
arielmelendez,
dtfiedler,
matibat and
atticusofsparta
matibat
previously approved these changes
Dec 11, 2023
feat: add a redeem page PE-5162
fedellen
force-pushed
the
PE-5161_gift_app_init
branch
from
8494951 to
ec02b7b
Compare
fedellen
force-pushed
the
PE-5161_gift_app_init
branch
from
de6672b to
13e5a6b
Compare
dtfiedler
reviewed
Dec 13, 2023
| @@ -3,6 +3,7 @@ | |||
| "version": "1.0.0", | |||
| "type": "module", | |||
There was a problem hiding this comment.
consider using nodenext in the tsconfig
feat: receieve query params in gift url PE-5161
dtfiedler
reviewed
Dec 13, 2023
| @@ -14,12 +15,14 @@ | |||
| "build": "tsc && vite build", | |||
| "lint": "eslint . --ext ts,tsx --report-unused-disable-directives --max-warnings 0", | |||
| "format": "prettier --write \"src/**/*.{js,jsx,ts,tsx}\"", | |||
| "preview": "vite preview" | |||
| "preview": "vite preview", | |||
| "test": "echo \"TODO: add tests\" && exit 0" | |||
| }, | |||
| "dependencies": { | |||
| "@ardrive/turbo-sdk": "^1.1.0", | |||
There was a problem hiding this comment.
can you test v1.1.1-alpha-1 and see if it removes the need for vite polyfill plugin below?
There was a problem hiding this comment.
#7 -- It did not seem to fix the problem there
There was a problem hiding this comment.
all good - will continue validating on that branch
fedellen
dismissed stale reviews from matibat and dtfiedler
The base branch was changed.
dtfiedler
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.