-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PE-5254: Hackathon - Hide feature #1530
Merged
Merged
Changes from 14 commits
Commits
Show all changes
113 commits
Select commit
Hold shift + click to select a range
ff9d21f
feat(database): adds the isHidden column to file and folder revision …
matibat e1807f1
feat(hide bloc): implements the bloc PE-5254
matibat 874619c
test(hide bloc): updates the affected unit tests PE-5254
matibat 58421c1
feat(hide bloc): lets the drive explorer not to show hidden items PE-…
matibat 6ca3fb2
chore(drive detail list): minot fix PE-5254
matibat fb5fa24
feat(hide bloc): now able to hide folders and files PE-5254
matibat 4a634ea
feat(hide bloc): now able to show hidden files PE-5254
matibat 9db3380
feat(hide bloc): makes it distinguish between hidden and non-hidden i…
matibat e489781
feat(hide bloc): properly consider hidden folders to be hidden PE-5254
matibat 1d4a980
feat(drive detail): instantly updates the drive detail content when s…
matibat d8dcdf9
test(arfs version): corrects broken tests PE-5154
matibat 9934496
feat(hide feature): enable for mobile view PE-5354
matibat 85f637d
feat(hide feature): confirmation modal PE-5354
matibat b31069f
chore(hide feature): removes unused methods PE-5254
matibat 135bbe9
chore(hackathon): cleanup PE-5254
matibat 36aa83e
chore(hackathon): removes unused variables and imports PE-5254
matibat ae70172
feat(hide dialog): makes it behave the same way as rename/move PE-5254
matibat d4052c0
Merge remote-tracking branch 'origin/dev' into PE-5254
matibat e1ae261
chore(hide dialog): cleanup PE-5254
matibat 17c9ab2
feat(hide feature): puts the reveal button as an option in the drive …
matibat 74a81b0
feat(app shell): removes unnecessary spacing PE-5310
matibat 27d941c
chore(app shell): removes unncessary const keyword PE-5310
matibat 221cd32
feat(localization en): adds wordings PE-5310
matibat b3ece07
feat(drive detail page): clenup PE-5310
matibat 849ec49
feat(drive detail data): re-enables multi-select when not showing hid…
matibat bff5945
Merge pull request #1535 from ardriveapp/PE-5310
matibat 2e44a74
Merge pull request #1536 from ardriveapp/PE-5317
matibat be58b34
feat(drive details panel): adds a button to hide/unhide items; improv…
matibat c03dab8
test(entity version tag): updates failing tests PE-5309
matibat cfcab10
Merge remote-tracking branch 'origin/PE-5254' into PE-5309
matibat 076b424
Merge remote-tracking branch 'origin/dev' into PE-5254
matibat fe03b09
Merge remote-tracking branch 'origin/PE-5254' into PE-5309
matibat 340bca1
chore(hygiene): cleans up the code PE-5309
matibat 2fe2208
feat(hide feature): sets up error handling PE-5309
matibat 0e4f36c
feat(hide dialog): adds localizations PE-5309
matibat 570879e
Merge pull request #1543 from ardriveapp/PE-5309
matibat a35214b
feat(localization en): hide and unhide PE-5254
matibat 6873b92
chore(app top bar): reverts unnecessary changes PE-5254
matibat 009aa85
feat(image preview): navigate only through visible images PE-5345
matibat b7b0a6f
feat(move form): makes the form list only visible folders where to mo…
matibat 47cb85c
chore(isHidden parameter): makes it default to false; removes unneces…
matibat 14a8725
chore(drive detail data list): adds comment PE-5254
matibat 1af52e0
Merge remote-tracking branch 'origin/dev' into PE-5254
matibat b6dbe26
feat(logger): corrects wrong import PE-5254
matibat cd93ab9
feat(drive detail data list): reverts unnecessary change PE-5254
matibat b11ffc7
feat(drive detail data list): reverts unnecessary change PE-5254
matibat d631f7f
feat(database migration): migrate also the entries tables PE-5254
matibat 982bb9f
feat(hide event): makes the equatable props include hideAction PE-5254
matibat 5103eb5
feat(hide state): makes the abstract class declare the props PE-5254
matibat bc1442d
feat(hide/unhide icon for dropdown): makes it use the eye one PE-5254
matibat 4dee8b7
feat(is hidden filter): factors out the code into its own reusable me…
matibat 111fcfd
test(is hidden filter): implements unit tests PE-5254
matibat b524d77
feat(drive detail cubit): re-emit the state instead of opening the sa…
matibat 5528a0b
chore(hide bloc): changes late for final variable declarations PE-5254
matibat 95b87db
feat(drive detail cubit): reverts unnecessary change PE-5254
matibat 59dc551
feat(folder with contents): reverts unnecessary change PE-5254
matibat 3c8bea2
chore(hide bloc): DRY it out PE-5254
matibat d0ef9c5
feat(drive explorer item title): adds hide dropdown option PE-5254
matibat c22fca0
chore(promptToToggleHideState): generalizes the method PE-5254
matibat 707c217
chore(drive dao): reverts unnecessary change PE-5254
matibat 5b3ccb2
feat(hide bloc): corrects unused variable PE-5254
matibat 11eb6be
feat(upload method selector)
thiagocarvalhodev e67179f
feat(payment selector)
thiagocarvalhodev fb175c0
feat(upload method)
thiagocarvalhodev b684d65
refactor(upload payment)
thiagocarvalhodev 78c744f
Update upload_payment_method_bloc.dart
thiagocarvalhodev 6f1dc8e
Merge pull request #1561 from ardriveapp/PE-5443-refactor-select-paym…
thiagocarvalhodev 69607cd
optimize list
karlprieb 57d6948
Merge pull request #1544 from ardriveapp/PE-5345
karlprieb 3fb4853
Merge pull request #1545 from ardriveapp/PE-5346
karlprieb 8a0e78f
change content type when renaming a file
thiagocarvalhodev b34c1c1
Update file_entity.dart
thiagocarvalhodev 6434d90
Update hide_state.dart
thiagocarvalhodev d23f89e
refactor
thiagocarvalhodev 69c698b
Update drive_explorer_item_tile.dart
thiagocarvalhodev 74ea824
Update drive_explorer_item_tile.dart
thiagocarvalhodev 78f1bf6
Merge branch 'dev' into PE-5254
karlprieb b3d740d
fix(hide): fix bug with non hidden items being concealed on load
atticusofsparta 8ccb7a2
fix(manifest creation): do not include hidden files in manifests
atticusofsparta 89006aa
Merge branch 'dev' into PE-5254
atticusofsparta 25b2be7
chore(merge): update with dev branch changes
atticusofsparta d8ec111
fix(lint): fixed blocking lint issues
atticusofsparta 9f60327
Merge branch 'PE-5254' into PE-5510-manifest-with-hidden-files
atticusofsparta a80ca2f
Merge branch 'PE-5254' into PE-5509-conceal-items-bug
atticusofsparta 60f1270
fix(merge): fix moved providers block
atticusofsparta 7bdfc15
Merge branch 'PE-5254' into PE-5509-conceal-items-bug
atticusofsparta f93bb4e
Merge branch 'PE-5254' into PE-5510-manifest-with-hidden-files
atticusofsparta 2f5a535
fix(providers): fix provider configuration for hide bloc
atticusofsparta 0ba310e
Merge branch 'PE-5254' into PE-5509-conceal-items-bug
atticusofsparta 45512da
Merge branch 'PE-5254' into PE-5510-manifest-with-hidden-files
atticusofsparta 2fd45d8
fix(hide): fixes issue with hiding non hidden files
atticusofsparta f4c02c1
Merge pull request #1582 from ardriveapp/PE-5528-concealed-files-fixes
atticusofsparta 9542f14
Update fs_entry_move_bloc.dart
thiagocarvalhodev 0d38f02
feat(hide)
thiagocarvalhodev 5a11f83
Merge branch 'dev' into PE-5534-hidden-file-movement-possible
thiagocarvalhodev 7aef415
Update hide_dialog.dart
thiagocarvalhodev a3a7c16
Update fs_entry_move_bloc_test.dart
thiagocarvalhodev 43d799f
fix(mobile): update filter for hidden items on mobile
atticusofsparta 02ecdc9
Update create_manifest_form.dart
thiagocarvalhodev be0ef96
Update create_manifest_form.dart
thiagocarvalhodev dfd4041
Update create_manifest_form.dart
thiagocarvalhodev 12ae082
Update drive_detail_page.dart
thiagocarvalhodev d974240
Update drive_detail_page.dart
thiagocarvalhodev ba073ba
Merge pull request #1585 from ardriveapp/PE-5534-hidden-file-movement…
thiagocarvalhodev 82be306
fix(hasFiles): update filter logic for hasFiles and hasFoders
atticusofsparta b4fd47c
fix(hasFiles): update filter logic for hasFiles and hasFolders
atticusofsparta 3f47fb1
Merge branch 'PE-5510-manifest-with-hidden-files' into PE-5509-concea…
thiagocarvalhodev 9587ad6
Merge branch 'PE-5509-conceal-items-bug' of github.com:ardriveapp/ard…
thiagocarvalhodev 874da72
Merge pull request #1577 from ardriveapp/PE-5509-conceal-items-bug
thiagocarvalhodev d46ae42
Merge branch 'dev' into PE-5510-manifest-with-hidden-files
thiagocarvalhodev 053fe81
Merge pull request #1578 from ardriveapp/PE-5510-manifest-with-hidden…
thiagocarvalhodev a9de18d
Update fs_entry_move_bloc.dart
thiagocarvalhodev ced0778
Merge pull request #1593 from ardriveapp/PE-5534
thiagocarvalhodev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
try to use
refreshDriveDataTable
insteadThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Calling it here won't have any effect because by this point, the folder subscription already ignored the event. We should instead call that method before writing the items to the DB.Edit - We're not writing anything to the DB.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to edit that method but got it working: b524d77