Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PE-5254: Hackathon - Hide feature #1530

Merged
merged 113 commits into from
Jan 31, 2024
Merged

PE-5254: Hackathon - Hide feature #1530

merged 113 commits into from
Jan 31, 2024

Conversation

matibat
Copy link
Contributor

@matibat matibat commented Dec 19, 2023 •
edited by github-actions bot
Loading

Changes

  • Introduces new tagging for hidden files and folders.
  • Persists the new tag.
  • Can add and remove the tag. I.e. hide and unhide items.
  • Can reveal hidden items.

--- Releases ---
Android release: https://appdistribution.firebase.google.com/testerapps/1:305132849030:android:6cf0cd5ec064fad3ffce07/releases/3et414r3tbeco

@matibat matibat self-assigned this Dec 19, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 19, 2023 •
edited
Loading

Visit the preview URL for this PR (updated for commit ced0778):

https://ardrive-web--pr1530-pe-5254-yvzlsw6q.web.app

(expires Wed, 07 Feb 2024 15:15:55 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: a224ebaee2f0939e7665e7630e7d3d6cd7d0f8b0

matibat
matibat commented Jan 2, 2024
View reviewed changes
Copy link
Contributor Author

@matibat matibat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-review checkpoint.

lib/blocs/drive_detail/drive_detail_cubit.dart Outdated Show resolved Hide resolved
lib/blocs/drive_detail/drive_detail_cubit.dart Outdated Show resolved Hide resolved
lib/blocs/drive_detail/drive_detail_cubit.dart Outdated Show resolved Hide resolved
lib/blocs/drive_detail/drive_detail_cubit.dart Outdated Show resolved Hide resolved
lib/blocs/drive_detail/drive_detail_cubit.dart Outdated Show resolved Hide resolved
lib/pages/drive_detail/components/drive_detail_data_list.dart Outdated Show resolved Hide resolved
lib/pages/drive_detail/components/drive_explorer_item_tile.dart Outdated Show resolved Hide resolved
lib/pages/drive_detail/components/drive_explorer_item_tile.dart Show resolved Hide resolved
lib/pages/drive_detail/drive_detail_page.dart Outdated Show resolved Hide resolved
lib/pages/drive_detail/drive_detail_page.dart Outdated Show resolved Hide resolved
matibat added 13 commits January 2, 2024 13:24
@matibat
chore(hackathon): cleanup PE-5254
135bbe9
@matibat
chore(hackathon): removes unused variables and imports PE-5254
36aa83e
@matibat
feat(hide dialog): makes it behave the same way as rename/move PE-5254
ae70172
@matibat
Merge remote-tracking branch 'origin/dev' into PE-5254
d4052c0
@matibat
chore(hide dialog): cleanup PE-5254
e1ae261
@matibat
feat(hide feature): puts the reveal button as an option in the drive …
17c9ab2 
…dropdown PE-5310
@matibat
feat(app shell): removes unnecessary spacing PE-5310
74a81b0
@matibat
chore(app shell): removes unncessary const keyword PE-5310
27d941c
@matibat
feat(localization en): adds wordings PE-5310
221cd32
@matibat
feat(drive detail page): clenup PE-5310
b3ece07
@matibat
feat(drive detail data): re-enables multi-select when not showing hid…
849ec49 
…den files PE-5317
@matibat
Merge pull request #1535 from ardriveapp/PE-5310
bff5945 
PE-5310: Puts the reveal button as an option in the drive dropdown
@matibat
Merge pull request #1536 from ardriveapp/PE-5317
2e44a74 
PE-5317: re-enables multi-select when not showing hidden files
atticusofsparta and others added 27 commits January 29, 2024 09:01
@atticusofsparta
Merge branch 'PE-5254' into PE-5510-manifest-with-hidden-files
f93bb4e
@atticusofsparta
fix(providers): fix provider configuration for hide bloc
2f5a535
@atticusofsparta
Merge branch 'PE-5254' into PE-5509-conceal-items-bug
0ba310e
@atticusofsparta
Merge branch 'PE-5254' into PE-5510-manifest-with-hidden-files
45512da
@atticusofsparta
fix(hide): fixes issue with hiding non hidden files
2fd45d8
@atticusofsparta
Merge pull request #1582 from ardriveapp/PE-5528-concealed-files-fixes
f4c02c1 
PE-5528: concealed files fixes
@thiagocarvalhodev
Update fs_entry_move_bloc.dart
9542f14 
dont move hidden files
@thiagocarvalhodev
feat(hide)
0d38f02 
only hide visible files
add empty state when there's no visible files
@thiagocarvalhodev
Merge branch 'dev' into PE-5534-hidden-file-movement-possible
5a11f83
@thiagocarvalhodev
Update hide_dialog.dart
7aef415
@thiagocarvalhodev
Update fs_entry_move_bloc_test.dart
a3a7c16
@atticusofsparta
fix(mobile): update filter for hidden items on mobile
43d799f
@thiagocarvalhodev
Update create_manifest_form.dart
02ecdc9 
- add warning for hidden files
@thiagocarvalhodev
Update create_manifest_form.dart
be0ef96 
- dont show hidden files on manifest creation
@thiagocarvalhodev
Update create_manifest_form.dart
dfd4041
@thiagocarvalhodev
Update drive_detail_page.dart
12ae082
@thiagocarvalhodev
Update drive_detail_page.dart
d974240
@thiagocarvalhodev
Merge pull request #1585 from ardriveapp/PE-5534-hidden-file-movement…
ba073ba 
…-possible

PE-5534: hidden file movement possible
@atticusofsparta
fix(hasFiles): update filter logic for hasFiles and hasFoders
82be306
@atticusofsparta
fix(hasFiles): update filter logic for hasFiles and hasFolders
b4fd47c
@thiagocarvalhodev
Merge branch 'PE-5510-manifest-with-hidden-files' into PE-5509-concea…
3f47fb1 
…l-items-bug
@thiagocarvalhodev
Merge branch 'PE-5509-conceal-items-bug' of github.com:ardriveapp/ard…
9587ad6 
…rive-web into PE-5509-conceal-items-bug
@thiagocarvalhodev
Merge pull request #1577 from ardriveapp/PE-5509-conceal-items-bug
874da72 
PE-5509: fix conceal items bug
@thiagocarvalhodev
Merge branch 'dev' into PE-5510-manifest-with-hidden-files
d46ae42
@thiagocarvalhodev
Merge pull request #1578 from ardriveapp/PE-5510-manifest-with-hidden…
053fe81 
…-files

PE-5510: Do not include hidden files in manifest creation
@thiagocarvalhodev
Update fs_entry_move_bloc.dart
a9de18d
@thiagocarvalhodev
Merge pull request #1593 from ardriveapp/PE-5534
ced0778 
PE-5534
@thiagocarvalhodev thiagocarvalhodev merged commit 3d7daa8 into dev Jan 31, 2024
6 checks passed
@thiagocarvalhodev thiagocarvalhodev deleted the PE-5254 branch January 31, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagocarvalhodev thiagocarvalhodev thiagocarvalhodev approved these changes

@karlprieb karlprieb karlprieb left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matibat @karlprieb @thiagocarvalhodev @atticusofsparta