fix(gar): do not remove delegate before decreasing stake #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtfiedler
commented
Dec 18, 2024
| @@ -395,7 +395,6 @@ local function assertAndSanitizeInputs(msg) | |||
| .. msg.Timestamp | |||
| ) | |||
| assert(msg.From, "From is required") | |||
| assert(msg.Id, "Id is required") | |||
There was a problem hiding this comment.
this was blocking some dry-runs like Info - but not others 🤔
dtfiedler
commented
Dec 18, 2024
| @@ -2055,7 +2067,6 @@ function unlockGatewayDelegateVault(gateway, delegateAddress, vaultId) | |||
| assert(vault, "Vault not found") | |||
|
|
|||
| balances.increaseBalance(delegateAddress, vault.balance) | |||
| gateway.delegates[delegateAddress] = nil | |||
There was a problem hiding this comment.
we nil out delegate in decreaseDelegateStakeAtGateway if necessary
There was a problem hiding this comment.
actually need to change - i don't think we should be calling decreaseDelegateStakeAtGateway here
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #283 +/- ##
===========================================
+ Coverage 94.42% 94.44% +0.02%
===========================================
Files 10 10
Lines 2976 2987 +11
===========================================
+ Hits 2810 2821 +11
Misses 166 166 ☔ View full report in Codecov by Sentry. |
dtfiedler
commented
Dec 18, 2024
| assert(delegate, "Delegate is required") | ||
| -- zero is allowed as it is a no-op | ||
| assert( | ||
| quantity and utils.isInteger(quantity) and quantity >= 0, |
There was a problem hiding this comment.
nit: we could change this to be greater than the delegate.totalDelegatedStake
fedellen
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.