fix(gar): do not remove delegate before decreasing stake (#283)

src/gar.lua

@@ -479,6 +479,13 @@ end
 --- @param gateway Gateway
 --- @param quantity mARIO
 function increaseDelegateStakeAtGateway(delegate, gateway, quantity)
+	assert(delegate, "Delegate is required")
+	assert(gateway, "Gateway is required")
+	-- zero is allowed as it is a no-op
+	assert(
+		quantity and utils.isInteger(quantity) and quantity >= 0,
+		"Quantity is required and must be an integer greater than or equal to 0: " .. quantity
+	)
 	delegate.delegatedStake = delegate.delegatedStake + quantity
 	gateway.totalDelegatedStake = gateway.totalDelegatedStake + quantity
 end
@@ -489,8 +496,15 @@ end
 --- @param ban boolean|nil do not add the delegate back to the gateway allowlist if their delegation is over
 function decreaseDelegateStakeAtGateway(delegateAddress, gateway, quantity, ban)
 	local delegate = gateway.delegates[delegateAddress]
-	-- use this in an inverse way
-	increaseDelegateStakeAtGateway(delegate, gateway, -quantity)
+	assert(delegate, "Delegate is required")
+	-- zero is allowed as it is a no-op
+	assert(
+		quantity and utils.isInteger(quantity) and quantity >= 0,
+		"Quantity is required and must be an integer greater than or equal to 0: " .. quantity
+	)
+	assert(gateway, "Gateway is required")
+	delegate.delegatedStake = delegate.delegatedStake - quantity
+	gateway.totalDelegatedStake = gateway.totalDelegatedStake - quantity
 	gar.pruneDelegateFromGatewayIfNecessary(delegateAddress, gateway)
 	if ban and gateway.settings.allowedDelegatesLookup then
 		gateway.settings.allowedDelegatesLookup[delegateAddress] = nil
@@ -2055,8 +2069,9 @@ function unlockGatewayDelegateVault(gateway, delegateAddress, vaultId)
 	assert(vault, "Vault not found")
 
 	balances.increaseBalance(delegateAddress, vault.balance)
-	gateway.delegates[delegateAddress] = nil
-	decreaseDelegateStakeAtGateway(delegateAddress, gateway, vault.balance)
+	-- delete the delegate's vault and prune the delegate if necessary
+	gateway.delegates[delegateAddress].vaults[vaultId] = nil
+	gar.pruneDelegateFromGatewayIfNecessary(delegateAddress, gateway)
 end
 
 --- @param gateway Gateway

src/main.lua

@@ -395,7 +395,6 @@ local function assertAndSanitizeInputs(msg)
 			.. msg.Timestamp
 	)
 	assert(msg.From, "From is required")
-	assert(msg.Id, "Id is required")
 	assert(msg.Tags and type(msg.Tags) == "table", "Tags are required")
 
 	msg.Tags = utils.validateAndSanitizeInputs(msg.Tags)