-
-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Bump androidx.test.uiautomator:uiautomator version to 2.3.0-beta01 #591
Conversation
Linking appium/appium#19597 |
I started my tests on correct functioning of the framework, everything is good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll take a look again tonight. It looks good overall.
this.wrappedInstance = wrappedInstance; | ||
Gestures(int displayId) { | ||
this.displayId = displayId; | ||
// https://androidx.tech/artifacts/test.uiautomator/uiautomator/2.3.0-beta01-source/androidx/test/uiautomator/Gestures.java.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have compared the diff, 2.2.0 and 2.3.0, so they started considering displayId as a big diff. Interesting
I did a couple of gesture actions as well. It looks good. Hmm, CI is probably more flaky than 2.2.0...? (not sure it could be the uiautomator library side tho...) |
@KazuCocoa Yes, the CI seems to be flaky, I've retried and it helped a bit. |
I meant some gesture actions manually with a real device worked but not for the integration test. Let me run the same integration test with a real device on my local later if the flakiness is acceptable right now as this pr change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. i made one test scenario improvement pr #593 that failed on my local and current master was not correct for the test's description.
It also worked with this pr.
mm, the semantics-release hasn't picked up this change...? |
Technically it is not a breaking change, although I expect some things might be broken because of the bump and significant changes in the dependent lib. So it would be safer to bump the major version and carefully check the integration with the driver first.