feat: bump targetSdkVersion to 34 #587
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KazuCocoa
changed the title
|
Maybe we should let the server to run for a while with the current changes before bumping it again? Otherwise it might be hard to find a failure reason if too many changes are published within a short period of time. |
|
Possibly yes. So far, I assume with this change for Android 14 is the most biggest than previous updates especially non-sdk interface changes. https://developer.android.com/about/versions/14/changes/non-sdk-14 has csv file for the non-SDK interface in Android 14. So Android 14 with this target version update could cause some potential issues I haven't found in major usage such as page source, device info, find element etc in my quick testing. |
This was referenced Dec 30, 2023
|
#591 included this change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once concern was regex related, but in my testing with this build on android 14 with page source, find element with XPath and send keys did not have any errors. Maybe should be ok. Lets see how CI will be...