-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Automate the release process #596
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janbuchar
added
the
t-tooling
Issues with this label are in the ownership of the tooling team.
label
Oct 23, 2024
@vladfrangu I'm tagging you because I'll try to do the same thing to CLI next. What do you think? |
vladfrangu
previously requested changes
Oct 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall tho I am loving what I see here 🎉, this has been needed for faaar too long
janbuchar
added a commit
to apify/crawlee-python
that referenced
this pull request
Oct 30, 2024
- see discussion in apify/apify-client-js#596 (comment)
B4nan
approved these changes
Nov 1, 2024
B4nan
dismissed
vladfrangu’s stale review
November 1, 2024 09:23
should be all addressed (and we cant merge now :D)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is essentially the same thing that we do in apify/apify-sdk-python, apify/crawlee-python, etc., but for Javascript.